test: stricten readline keypress failure test condition#31300
Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Closed
test: stricten readline keypress failure test condition#31300BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Conversation
This verifies that the thrown error is the expected one. That was not tested before.
addaleax
approved these changes
Jan 10, 2020
lpinca
approved these changes
Jan 10, 2020
Collaborator
ZYSzys
approved these changes
Jan 11, 2020
ZYSzys
added
the
author ready
Collaborator
Trott
reviewed
Jan 12, 2020
| } catch { } | ||
| assert.throws( | ||
| () => fi.emit('data', 'fooX'), | ||
| (e) => { |
Member
There was a problem hiding this comment.
Instead of a validation function, can't this just be err?
Member
Author
There was a problem hiding this comment.
That would also work but I wanted to have a reference equality check. That would not be checked if I'd use err directly.
Trott
approved these changes
Jan 12, 2020
BridgeAR
added a commit
that referenced
this pull request
Jan 12, 2020
This verifies that the thrown error is the expected one. That was not tested before. PR-URL: #31300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
Author
|
Landed in 7952467 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
This verifies that the thrown error is the expected one. That was not tested before. PR-URL: #31300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
This verifies that the thrown error is the expected one. That was not tested before. PR-URL: #31300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
This verifies that the thrown error is the expected one. That was not tested before. PR-URL: #31300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This verifies that the thrown error is the expected one. That was
not tested before.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes