doc: update README to make Node.js description clearer#31266
Closed
carterbancroft wants to merge 1 commit intonodejs:masterfrom
Closed
doc: update README to make Node.js description clearer#31266carterbancroft wants to merge 1 commit intonodejs:masterfrom
carterbancroft wants to merge 1 commit intonodejs:masterfrom
Conversation
devnexen
approved these changes
Jan 9, 2020
gireeshpunathil
approved these changes
Jan 9, 2020
lpinca
approved these changes
Jan 9, 2020
BridgeAR
approved these changes
Jan 9, 2020
BridgeAR
added
the
author ready
Trott
approved these changes
Jan 10, 2020
Member
|
Landed in 6d44308 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 11, 2020
Fixes: nodejs#24872 PR-URL: nodejs#31266 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #24872
This PR updates the README's original description:
To:
Based on the two sentence suggestion from the issue discussion.
Checklist