https-agent: fix issue where creating connection modifies arguments

[vighnesh153]

Previously, when passing options object to the agent.createConnection
method, the same options object got modified within the method. Now,
any modification will happen on only a copy of the object.

Fixes: #31119

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[antsmartian]

@vighnesh153 Welcome and thanks for your first PR! There are few slight issues in the PR:

Lint has been failed (run make lint locally to verify). These are the errors:

/home/travis/build/nodejs/node/test/parallel/test-https-agent-create-connection.js
  152:7  error  'assert.equal' is restricted from being used. Use `assert.strictEqual()` rather than `assert.equal()`  no-restricted-properties
  153:7  error  'assert.equal' is restricted from being used. Use `assert.strictEqual()` rather than `assert.equal()`  no-restricted-properties
✖ 2 problems (2 errors, 0 warnings)

Also, we need to follow commit guidelines mentioned over here: https://goo.gl/p2fr5Q. I have copied the failure for you (from CI:https://travis-ci.com/nodejs/node/jobs/271698472):

  ✖  85fcbdc557f73ea3f16882d1f8ee849c8ea1c247
     ✔  5:7      Valid fixes URL.                          fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✖  0:0      Invalid subsystem: "https-agent"          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length

[vighnesh153]

@vighnesh153 Welcome and thanks for your first PR! There are few slight issues in the PR:

Lint has been failed (run make lint locally to verify). These are the errors:

/home/travis/build/nodejs/node/test/parallel/test-https-agent-create-connection.js
  152:7  error  'assert.equal' is restricted from being used. Use `assert.strictEqual()` rather than `assert.equal()`  no-restricted-properties
  153:7  error  'assert.equal' is restricted from being used. Use `assert.strictEqual()` rather than `assert.equal()`  no-restricted-properties
✖ 2 problems (2 errors, 0 warnings)

Also, we need to follow commit guidelines mentioned over here: https://goo.gl/p2fr5Q. I have copied the failure for you (from CI:https://travis-ci.com/nodejs/node/jobs/271698472):

  ✖  85fcbdc557f73ea3f16882d1f8ee849c8ea1c247
     ✔  5:7      Valid fixes URL.                          fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✖  0:0      Invalid subsystem: "https-agent"          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length

Got it. I will work on it right away. So, should I open a new PR as there are multiple commits for a single change or should I continue with this?

[antsmartian]

No need to open a new PR. It would be great if you can squash all your commits.

[vighnesh153]

No need to open a new PR. It would be great if you can squash all your commits.

Alright. Thanks man. Fixing it now.

[vighnesh153]

@antsmartian Please have a look and please give me feedback about anything that needs to be changed.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/28092/

[mscdex]

One other nit: in general, commit messages should be structured such that they start with a verb to make it clear what the commit is doing.

So instead of: https: Agent.createConnection mutates options object
Consider something like: https: prevent options object from being mutated

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/28180/

[Trott]

Landed in fa94698.

Thanks for the contribution! 🎉