tools: remove prefer-common-expectserror lint rule#31147
Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
Closed
tools: remove prefer-common-expectserror lint rule#31147cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig wants to merge 1 commit intonodejs:masterfrom
Conversation
This custom ESLint rule is unused since nodejs#31092. This commit removes it.
BridgeAR
approved these changes
Dec 31, 2019
devnexen
approved these changes
Dec 31, 2019
antsmartian
approved these changes
Dec 31, 2019
antsmartian
added
the
author ready
lpinca
approved these changes
Dec 31, 2019
Collaborator
Collaborator
Trott
approved these changes
Dec 31, 2019
gengjiawen
approved these changes
Jan 1, 2020
watilde
approved these changes
Jan 1, 2020
Collaborator
jasnell
approved these changes
Jan 2, 2020
Member
|
Landed in b8d2ba6 |
Trott
pushed a commit
that referenced
this pull request
Jan 2, 2020
This custom ESLint rule is unused since #31092. This commit removes it. PR-URL: #31147 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
This custom ESLint rule is unused since #31092. This commit removes it. PR-URL: #31147 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Member
|
Needs #31092 to land on v12.x-staging |
targos
removed
the
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
This custom ESLint rule is unused since nodejs#31092. This commit removes it. PR-URL: nodejs#31147 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
This custom ESLint rule is unused since #31092. This commit removes it. PR-URL: #31147 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This custom ESLint rule is unused since #31092. This commit removes it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes