esm: better error message for unsupported URL#31129
Closed
Hakerh400 wants to merge 1 commit intonodejs:masterfrom
Hakerh400:esm-url
Closed
esm: better error message for unsupported URL#31129Hakerh400 wants to merge 1 commit intonodejs:masterfrom Hakerh400:esm-url
Hakerh400 wants to merge 1 commit intonodejs:masterfrom
Hakerh400:esm-url
Conversation
nodejs-github-bot
added
errors
Contributor
Author
|
test/es-module/test-esm-dynamic-import.js // TODO(jkrems): Right now this doesn't hit a protocol error because the
// module resolution step already rejects it. These arguably should be
// protocol errors.
expectMissingModuleError(import('node:fs'));
expectMissingModuleError(import('http://example.com/foo.js'));This is the only test failing right now. The problem is that the loader converts the url to a file url and ignores the url scheme, producing a misleading error message (and it may probably load a wrong module). Should we update this test to check for |
devsnek
suggested changes
Dec 29, 2019
Member
devsnek
left a comment
devsnek
left a comment
There was a problem hiding this comment.
you can use parsed.scheme a few lines down.
devsnek
reviewed
Dec 29, 2019
Trott
reviewed
Dec 29, 2019
guybedford
approved these changes
Dec 29, 2019
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Thanks for the PR, the approach looks great.
The test failures can be fixed by just changing the test expectations in https://github.com/nodejs/node/blob/master/test/es-module/test-esm-dynamic-import.js#L60. Note that the errors exactly align with a TODO comment @jkrems included previously.
The default ESM loader supports only file and data URLs. This PR adds better error message for it.
devsnek
approved these changes
Dec 29, 2019
jasnell
approved these changes
Dec 30, 2019
Trott
approved these changes
Dec 30, 2019
Collaborator
lpinca
approved these changes
Dec 30, 2019
Member
|
This is stalled on two issues in CI (nodejs/build#2116 and nodejs/build#2115) that will hopefully be resolved soon. |
BridgeAR
approved these changes
Jan 2, 2020
BridgeAR
approved these changes
Jan 2, 2020
BridgeAR
added
the
author ready
Collaborator
Collaborator
Collaborator
Member
|
Landed in a25a628 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 3, 2020
The default ESM loader supports only file and data URLs. This PR adds better error message for it. PR-URL: nodejs#31129 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
The default ESM loader supports only file and data URLs. This PR adds better error message for it. PR-URL: #31129 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 12, 2020
The default ESM loader supports only file and data URLs. This PR adds better error message for it. PR-URL: #31129 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
The default ESM loader supports only file and data URLs. This PR adds better error message for it. PR-URL: #31129 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default ESM loader supports only file and data URLs.
This PR adds better error message for it.
Fixes #31120
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes