docs: update parameters for chmod and chmodsync#31085
Closed
santoshyadavdev wants to merge 1 commit intonodejs:masterfrom
santoshyadavdev:patch-1
Closed
docs: update parameters for chmod and chmodsync#31085santoshyadavdev wants to merge 1 commit intonodejs:masterfrom santoshyadavdev:patch-1
santoshyadavdev wants to merge 1 commit intonodejs:masterfrom
santoshyadavdev:patch-1
Conversation
nodejs-github-bot
added
doc
gireeshpunathil
approved these changes
Dec 25, 2019
Member
Trott
approved these changes
Dec 25, 2019
Trott
added
the
author ready
jasnell
approved these changes
Dec 26, 2019
Contributor
Author
|
Thank you team, I have made the changes in commit message. |
trivikr
approved these changes
Dec 27, 2019
Member
|
@santoshyadav198613 Can you update the commit message to include a subsystem, a better description in the header, and punctuation in the body? If you just want to copy/paste, here's what I would recommend: |
Trott
removed
the
author ready
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or an integer. This change updates the documentation, which currently omits string as a valid type for mode.
Member
Never mind. I made the edits myself and pushed it to the branch. |
Trott
added
the
author ready
Contributor
Author
Sorry I also pushed the same changes. |
Member
Ha ha! Yeah, no problem. Thanks! |
Trott
approved these changes
Dec 27, 2019
Contributor
Author
Thanks, this was my first PR sorry for the trouble. |
Member
|
Landed in 283e7a4. Thanks for the contribution! 🎉 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 27, 2019
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or an integer. This change updates the documentation, which currently omits string as a valid type for mode. PR-URL: nodejs#31085 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Dec 27, 2019
This was overlooked in nodejs#31085.
3 tasks
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or an integer. This change updates the documentation, which currently omits string as a valid type for mode. PR-URL: #31085 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or an integer. This change updates the documentation, which currently omits string as a valid type for mode. PR-URL: #31085 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or an integer. This change updates the documentation, which currently omits string as a valid type for mode. PR-URL: #31085 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes