benchmark: include writev & callback in benchmark#31066
Closed
ronag wants to merge 5 commits intonodejs:masterfrom
Closed
benchmark: include writev & callback in benchmark#31066ronag wants to merge 5 commits intonodejs:masterfrom
ronag wants to merge 5 commits intonodejs:masterfrom
Conversation
Currently we only consider write when benchmarking.
nodejs-github-bot
added
benchmark
ronag
changed the title
ronag
force-pushed
the
many-writes-writev
branch
from
1f863ee to
4155712
Compare
lundibundi
approved these changes
Dec 23, 2019
4 tasks
addaleax
approved these changes
Dec 24, 2019
BridgeAR
approved these changes
Dec 24, 2019
BridgeAR
requested changes
Dec 24, 2019
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
This actually requires the following test to be changed:
test/benchmark/test-benchmark-streams.js
Member
Author
Sorry, this is new for me. What is that and how does it need to be changed? |
Member
|
If you run the test with this addition, it will fail due to the added options that are not included in the test. It is a way to verify that at least one benchmark option passes for all benchmark files of the specific subsystem. You could add something like |
BridgeAR
approved these changes
Dec 25, 2019
BridgeAR
added
the
author ready
Member
|
Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4115/ Marking as author ready. The benchmark test should be run while landing to verify that it works properly. |
Member
|
Landed in f68285b 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Dec 25, 2019
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we only consider write when benchmarking.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes