async_hooks: remove internal only error checking#30967
Closed
apapirovski wants to merge 3 commits intonodejs:masterfrom
Closed
async_hooks: remove internal only error checking#30967apapirovski wants to merge 3 commits intonodejs:masterfrom
apapirovski wants to merge 3 commits intonodejs:masterfrom
Conversation
This error checking is mostly unnecessary and is just a Node core developer nicety, rather than something that is needed for the user-land. It can be safely removed without any practical impact while making nextTick, timers, immediates and AsyncResource substantially faster.
nodejs-github-bot
added
the
async_hooks
This comment has been minimized.
This comment has been minimized.
Member
|
Not sure but CI results suggest that running |
Contributor
Author
Kinda. I just overestimated the ability to remove the current |
jasnell
approved these changes
Dec 15, 2019
Qard
approved these changes
Dec 21, 2019
Member
|
@apapirovski Can you add back the one bit of test-skipping code for workers so we can re-run CI and get this landed? |
Trott
approved these changes
Dec 21, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM once we get the test skipped in workers again.
BridgeAR
approved these changes
Dec 24, 2019
BridgeAR
added
author ready
Member
|
Ping @apapirovski |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/28303/ ✅ (yellow build with a known flake) |
apapirovski
added
author ready
Contributor
Author
|
The latest CI posted above passed without any issues. |
Member
|
Landed in 4de31d5 |
Trott
pushed a commit
that referenced
this pull request
Jan 12, 2020
This error checking is mostly unnecessary and is just a Node core developer nicety, rather than something that is needed for the user-land. It can be safely removed without any practical impact while making nextTick, timers, immediates and AsyncResource substantially faster. PR-URL: #30967 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
This error checking is mostly unnecessary and is just a Node core developer nicety, rather than something that is needed for the user-land. It can be safely removed without any practical impact while making nextTick, timers, immediates and AsyncResource substantially faster. PR-URL: #30967 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
This error checking is mostly unnecessary and is just a Node core developer nicety, rather than something that is needed for the user-land. It can be safely removed without any practical impact while making nextTick, timers, immediates and AsyncResource substantially faster. PR-URL: #30967 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
This error checking is mostly unnecessary and is just a Node core developer nicety, rather than something that is needed for the user-land. It can be safely removed without any practical impact while making nextTick, timers, immediates and AsyncResource substantially faster. PR-URL: #30967 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error checking is mostly unnecessary and is just a Node core developer nicety, rather than something that is needed for the user-land. It can be safely removed without any practical impact while making nextTick, timers, immediates and AsyncResource substantially faster.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes