doc: add note about fs.close undefined behavior#30966
Closed
ronag wants to merge 6 commits intonodejs:masterfrom
Closed
doc: add note about fs.close undefined behavior#30966ronag wants to merge 6 commits intonodejs:masterfrom
ronag wants to merge 6 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
Member
Author
addaleax
approved these changes
Dec 14, 2019
Member
Author
|
We might want to consider adding a ref count on |
Member
Author
|
Is that disagreement or confusion on the previous comment? |
Member
|
@ronag It’s both … I feel like the suggestion misses a compelling reason to be implemented? |
Member
Author
Consider the amount of users that are not aware of this quirk and are ending up unknowingly with code with undefined behaviour. I'm also sceptical whether that's compelling enough. Probably isn't as bad in practice as I make it sound. Just thought it might be worth to consider. |
Trott
reviewed
Dec 15, 2019
Trott
reviewed
Dec 15, 2019
Trott
approved these changes
Dec 15, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with two small suggestions applied.
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Member
Author
|
Added note to |
BridgeAR
approved these changes
Dec 15, 2019
BridgeAR
added
the
author ready
Member
lpinca
approved these changes
Dec 15, 2019
jasnell
approved these changes
Dec 15, 2019
ronag
commented
Dec 15, 2019
ronag
commented
Dec 15, 2019
Trott
pushed a commit
that referenced
this pull request
Dec 17, 2019
Add notes to fs.close and fs.closeSync() about udnefined behavior. PR-URL: #30966 Refs: #30864 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in b376965 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Add notes to fs.close and fs.closeSync() about udnefined behavior. PR-URL: #30966 Refs: #30864 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Add notes to fs.close and fs.closeSync() about udnefined behavior. PR-URL: #30966 Refs: #30864 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Add notes to fs.close and fs.closeSync() about udnefined behavior. PR-URL: #30966 Refs: #30864 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #30864
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes