lib: replace symbol.species by SymbolSpecies#30950
Closed
Sebastien-Ahkrin wants to merge 1 commit intonodejs:masterfrom
Closed
lib: replace symbol.species by SymbolSpecies#30950Sebastien-Ahkrin wants to merge 1 commit intonodejs:masterfrom
Sebastien-Ahkrin wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
buffer
Contributor
Author
|
Refs: #30697 |
cjihrig
approved these changes
Dec 13, 2019
targos
approved these changes
Dec 13, 2019
Sebastien-Ahkrin
force-pushed
the
SymbolSpecies
branch
from
165e76f to
e1dc6db
Compare
trivikr
approved these changes
Dec 14, 2019
Sebastien-Ahkrin
force-pushed
the
SymbolSpecies
branch
from
e1dc6db to
e920cef
Compare
devnexen
approved these changes
Dec 14, 2019
BridgeAR
approved these changes
Dec 15, 2019
BridgeAR
added
the
author ready
Collaborator
jasnell
approved these changes
Dec 15, 2019
Collaborator
targos
pushed a commit
that referenced
this pull request
Dec 16, 2019
PR-URL: #30950 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 437b6d5 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30950 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30950 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30950 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just replaced every Symbol.species by SymbolSpecies in the lib/* folder
For this, i just have added SymbolSpecies in the import
Of course i have removed unused import of Symbol 😄