Conversation
PR-URL: #30904 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
nodejs-github-bot
added
meta
Trott
approved these changes
Dec 13, 2019
cjihrig
approved these changes
Dec 13, 2019
Member
|
Is the CI expected to pass without recent commits for Windows by @joaocgreis? |
BethGriggs
approved these changes
Dec 13, 2019
Member
BethGriggs
left a comment
BethGriggs
left a comment
There was a problem hiding this comment.
LGTM (PR-URL: to be added)
Member
|
CI needs c3e3862 to pass. Ref: #30937 (comment) |
Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
added a commit
that referenced
this pull request
Dec 16, 2019
This is a security release. This release includes a single commit, an update to npm to 6.13.4. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: update npm to 6.13.4 - #30904 PR-URL: #30940
MylesBorins
force-pushed
the
v10.18.0-proposal
branch
from
46964cd to
4bd4b6b
Compare
Collaborator
This comment has been minimized.
This comment has been minimized.
This is a security release. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: update npm to 6.13.4 #30904 PR-URL: #30940
MylesBorins
force-pushed
the
v10.18.0-proposal
branch
from
4bd4b6b to
94365f0
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
Collaborator
Collaborator
Contributor
Author
|
Have a single failure that persists on arm As this failure is unrelated to this release, which only updates npm, I'm going to move forward with this test broken. |
MylesBorins
added a commit
that referenced
this pull request
Dec 17, 2019
This is a security release. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: update npm to 6.13.4 #30904 PR-URL: #30940
MylesBorins
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Dec 17, 2019
Refs: nodejs/node#30937 Refs: nodejs/node#30938 Refs: nodejs/node#30940 Refs: nodejs/node#30941
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2019-12-17, Version 10.18.0 'Dubnium' (LTS), @MylesBorins
This is a security release.
This release includes a single commit, an update to npm to 6.13.4.
For more details about the vulnerability please consult the npm blog:
https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli
Notable changes
Commits
f9b31edb25] - deps: update npm to 6.13.4 (Isaac Z. Schlueter) #30904