lib: minor fix equality comparison

[PW486]

Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[BridgeAR]

LGTM with a green CI

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/27584/

[targos]

don't we still treat punycode as an external dependency that we don't patch directly?

[BridgeAR]

@targos not anymore as far as I can tell. We did update e.g. var.

[Trott]

There was a very specific reason that we used == in prof_polyfill but I don't recall what it was.... Going to "request changes" for a bit while I dig through logs to try to find out. Sorry about that.

[Trott]

There was a very specific reason that we used == in prof_polyfill but I don't recall what it was.... Going to "request changes" for a bit while I dig through logs to try to find out. Sorry about that.

Argh, I see it was recently de-var'ed which I think might also be a problem. I might be confusing it with another file though.

@targos not anymore as far as I can tell. We did update e.g. var.

But it looks like maybe we upstreamed that change....

[Trott]

This should probably be split into two commits, one for each file?

[Trott]

@nodejs/v8 @matthewloring Am I wrong about == in v8_prof_polyfill.js being significant somehow? I'm guessing I'm wrong/mistaken/misremembering but I would really prefer to have that confirmed by someone knowledgable.

[BridgeAR]

@Trott here's an overview for loose equalities: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness#Loose_equality_using

Objects with a Symbol.toPrimitive or toString attached would work differently now (they could match before). Other comparison will not be impacted.

I do not know if that was intentional but I doubt it.

[Trott]

@Trott here's an overview for loose equalities: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness#Loose_equality_using

Objects with a Symbol.toPrimitive or toString attached would work differently now (they could match before). Other comparison will not be impacted.

I do not know if that was intentional but I doubt it.

I thought it had to do with side effects in V8 under the hood that would affect profiling but not anything normally visible to the end user. I'm probably wrong and will remove my request for changes.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/27644/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/27666/

[Trott]

Landed in 9c460e1.

Thanks for the contribution! 🎉