Skip to content

lib: replace Symbol.iterator by SymbolIterator#30859

Closed
Sebastien-Ahkrin wants to merge 1 commit intonodejs:masterfrom
Sebastien-Ahkrin:SymbolIterator
Closed

lib: replace Symbol.iterator by SymbolIterator#30859
Sebastien-Ahkrin wants to merge 1 commit intonodejs:masterfrom
Sebastien-Ahkrin:SymbolIterator

Conversation

@Sebastien-Ahkrin
Copy link
Contributor

Just replaced every Symbol.iterator by SymbolIterator in the lib/* folder

For this, i just have added SymbolIterator in the import

const {
  // [...]
  SymbolIterator,
} = primordials;

I hope this pull request will help you ! 😄

@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented Dec 11, 2019

Landed in c101251

@targos targos closed this Dec 11, 2019
targos pushed a commit that referenced this pull request Dec 11, 2019
PR-URL: #30859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2019
PR-URL: #30859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants