src: fix the false isatty() issue on IBMi by dmabupt · Pull Request #30829 · nodejs/node

dmabupt · 2019-12-07T03:01:36Z

IBMi PASE always says it is a tty terminal.
For ssh terminals it is true, but for terminals like TN5250 it is not.
Need to identify whether it is actually in a TTY or not.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

richardlau · 2019-12-07T03:21:18Z

Presumably this is related to https://www.ibm.com/support/pages/nodejs-failure-pase-error-560-assertion? (And, if so, setting the PASE_STDIO_ISATTY environment variable in code is not an option?)

dmabupt · 2019-12-07T03:31:47Z

Presumably this is related to https://www.ibm.com/support/pages/nodejs-failure-pase-error-560-assertion? (And, if so, setting the PASE_STDIO_ISATTY environment variable in code is not an option?)

Yes, that is the issue.
We can work around by setting PASE_STDIO_ISATTY=N but I think maybe it is better to directly get the result.

cjihrig · 2019-12-07T03:44:29Z

Somewhat related question: is it worth teaching uv_guess_handle() about this?

src/node.cc

richardlau · 2019-12-07T03:53:05Z

There are some linter failures:

https://travis-ci.com/nodejs/node/jobs/264279822#L301-L308

Running C++ linter...
src/node.cc:113:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
src/node.cc:562:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
src/node.cc:564:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
src/node.cc:565:  Use nullptr instead of NULL  [readability/null_usage] [2]
src/node.cc:566:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
Done processing src/node.cc
Total errors found: 5

nodejs-github-bot · 2019-12-07T13:48:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27452/

dmabupt · 2019-12-07T13:49:49Z

uv_guess_handle()

Hello @cjihrig , Do you know any API or test case using uv_guess_handle()? I found test/parallel/test-ttywrap-invalid-fd.js but it seems to be an internal case that I can not directly run?

richardlau · 2019-12-07T14:02:05Z

uv_guess_handle()

Hello @cjihrig , Do you know any API or test case using uv_guess_handle()? I found test/parallel/test-ttywrap-invalid-fd.js but it seems to be an internal case that I can not directly run?

@dmabupt If you're not running via the test runner (i.e. tools/test.py parallel/test-ttywrap-invalid-fd) you need to append the flags from the // Flags: comment (i.e. node --expose-internals test/parallel/test-ttywrap-invalid-fd.js).

libuv has its own tests that use uv_guess_handle(). See build instructions and running tests for how to build libuv and run tests (I assume you already know this since you've already contributed to libuv).

cjihrig · 2019-12-07T14:40:14Z

@dmabupt the documentation for uv_guess_handle() states:

For isatty(3) equivalent functionality use this function and test for UV_TTY.

So I just thought that while you're adding this functionality to Node, it would probably be worthwhile to add it to libuv as well. In fact, uv_guess_handle() could then be used to clean this code up a little bit (one less #ifdef).

dmabupt · 2019-12-08T02:51:08Z

@dmabupt the documentation for uv_guess_handle() states:

For isatty(3) equivalent functionality use this function and test for UV_TTY.

So I just thought that while you're adding this functionality to Node, it would probably be worthwhile to add it to libuv as well. In fact, uv_guess_handle() could then be used to clean this code up a little bit (one less #ifdef).

Thanks for the information. I have submiited a PR for that.

nodejs-github-bot · 2019-12-08T16:28:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27490/

nodejs-github-bot · 2019-12-08T16:47:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27492/

On IBMi PASE isatty() always returns true for stdin, stdout and stderr. Use ioctl() instead to identify whether it's actually a TTY.

dmabupt · 2019-12-09T04:34:27Z

I have updated the code to --

    if (ioctl(fd, TXISATTY + 0x81, nullptr) == -1 && errno == ENOTTY)
      continue;

to specifically detect the ENOTTY environment.

nodejs-github-bot · 2019-12-09T04:50:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27509/

mhdawson

LGTM

On IBMi PASE isatty() always returns true for stdin, stdout and stderr. Use ioctl() instead to identify whether it's actually a TTY. PR-URL: #30829 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BridgeAR · 2019-12-09T23:30:04Z

Landed in 68874a6 🎉

On IBMi PASE isatty() always returns true for stdin, stdout and stderr. Use ioctl() instead to identify whether it's actually a TTY. PR-URL: #30829 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

This commit reverts nodejs#30829 and uses uv_guess_handle() instead of isatty(). The IBMi changes are no longer required, as of libuv 1.34.1. PR-URL: nodejs#31333 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

This commit reverts #30829 and uses uv_guess_handle() instead of isatty(). The IBMi changes are no longer required, as of libuv 1.34.1. PR-URL: #31333 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

On IBMi PASE isatty() always returns true for stdin, stdout and stderr. Use ioctl() instead to identify whether it's actually a TTY. PR-URL: #30829 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

This commit reverts #30829 and uses uv_guess_handle() instead of isatty(). The IBMi changes are no longer required, as of libuv 1.34.1. PR-URL: #31333 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 7, 2019

richardlau approved these changes Dec 7, 2019

View reviewed changes

src/node.cc Outdated Show resolved Hide resolved

devnexen approved these changes Dec 7, 2019

View reviewed changes

richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2019

Trott approved these changes Dec 7, 2019

View reviewed changes

BridgeAR approved these changes Dec 8, 2019

View reviewed changes

src: fix the false isatty() issue on IBMi

5644ec6

On IBMi PASE isatty() always returns true for stdin, stdout and stderr. Use ioctl() instead to identify whether it's actually a TTY.

mhdawson approved these changes Dec 9, 2019

View reviewed changes

BridgeAR closed this Dec 9, 2019

dmabupt deleted the ibmi_isatty branch December 10, 2019 05:35

MylesBorins mentioned this pull request Dec 13, 2019

v13.4.0 proposal #30937

Merged

targos mentioned this pull request Jan 15, 2020

v12.15.0 release proposal #31368

Closed

MylesBorins mentioned this pull request Feb 8, 2020

v12.16.0 proposal #31691

Merged

Uh oh!

Conversation

dmabupt commented Dec 7, 2019

Checklist

Uh oh!

richardlau commented Dec 7, 2019

Uh oh!

dmabupt commented Dec 7, 2019

Uh oh!

cjihrig commented Dec 7, 2019

Uh oh!

Uh oh!

richardlau commented Dec 7, 2019

Uh oh!

nodejs-github-bot commented Dec 7, 2019

Uh oh!

dmabupt commented Dec 7, 2019

Uh oh!

richardlau commented Dec 7, 2019

Uh oh!

cjihrig commented Dec 7, 2019

Uh oh!

dmabupt commented Dec 8, 2019

Uh oh!

nodejs-github-bot commented Dec 8, 2019

Uh oh!

nodejs-github-bot commented Dec 8, 2019

Uh oh!

dmabupt commented Dec 9, 2019

Uh oh!

nodejs-github-bot commented Dec 9, 2019

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented Dec 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants