lib: add warning on dynamic import es modules#30720
Closed
juanarbol wants to merge 3 commits intonodejs:masterfrom
Closed
lib: add warning on dynamic import es modules#30720juanarbol wants to merge 3 commits intonodejs:masterfrom
juanarbol wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
process
Member
Author
|
Ref: #30601 |
Contributor
|
Can you add a test please. |
Member
Author
|
Sure, should I use a child process and test std err, or is there another way? |
Contributor
|
We have |
Member
Author
|
As long as const [ message, code ] = expected.shift();
^
TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator)) |
guybedford
requested changes
Dec 2, 2019
Member
Author
|
@guybedford Done! Thanks for reviewing! Tell me if something else is not correct. |
guybedford
added
the
esm
guybedford
approved these changes
Dec 7, 2019
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
This looks good to me.
Collaborator
guybedford
added
the
author ready
guybedford
pushed a commit
that referenced
this pull request
Dec 7, 2019
PR-URL: #30720 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Contributor
|
Landed in 6669cd1. |
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
PR-URL: #30720 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Merged
Member
|
Depends on #29866 to land on v12.x-staging |
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#30720 Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
May 7, 2020
PR-URL: nodejs#30720 Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos
added
backported-to-v12.x
and removed
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30601.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes