v8: remove "this API is unstable" note#30631
Closed
bruce-one wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
As nodejs#30234 marked this as stable I think this line should be removed as well?
bnoordhuis
approved these changes
Nov 25, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Good catch. Interesting that the other PR was signed off by no fewer than 9 people and no one noticed. ^^
Member
Perhaps because the default github diff doesn't show this text. |
gengjiawen
approved these changes
Nov 25, 2019
addaleax
approved these changes
Nov 25, 2019
cjihrig
approved these changes
Nov 25, 2019
lpinca
approved these changes
Nov 25, 2019
trivikr
approved these changes
Nov 26, 2019
antsmartian
approved these changes
Nov 26, 2019
addaleax
pushed a commit
that referenced
this pull request
Nov 27, 2019
As #30234 marked this as stable I think this line should be removed as well? Refs: #30234 PR-URL: #30631 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Member
|
Landed in 84aa192, thanks for noticing this and opening a PR! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
As #30234 marked this as stable I think this line should be removed as well? Refs: #30234 PR-URL: #30631 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
As #30234 marked this as stable I think this line should be removed as well? Refs: #30234 PR-URL: #30631 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
As #30234 marked this as stable I think this line should be removed as well? Refs: #30234 PR-URL: #30631 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #30234 marked this as stable I think this line should be removed as well?