Skip to content

test: skip test-domain-error-types in debug mode temporariliy#30629

Merged
Trott merged 1 commit intonodejs:masterfrom
Trott:skip-it
Nov 26, 2019
Merged

test: skip test-domain-error-types in debug mode temporariliy#30629
Trott merged 1 commit intonodejs:masterfrom
Trott:skip-it

Conversation

@Trott
Copy link
Member

@Trott Trott commented Nov 24, 2019

Until #30498 is resolved, skip
test-domain-error-types on debug builds.

Not my first choice, but the frequency of failures in container+debug+shared-lib here is a problem.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2019
@Trott Trott mentioned this pull request Nov 24, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 24, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26932/

richardlau
richardlau reviewed Nov 24, 2019
View reviewed changes
lundibundi
lundibundi reviewed Nov 24, 2019
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26939/

richardlau
richardlau requested changes Nov 25, 2019
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26960/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 25, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26969/

@Trott
Copy link
Member Author

Trott commented Nov 25, 2019

With the .status file approach, the test now doesn't show up at all in the results for the debug build. I would have thought it would be green-on-pass/yellow-on-fail. I'm puzzled by that. It is showing up in non-debug builds as expected.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2019 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/26970/ ✔️

@richardlau
Copy link
Member

richardlau commented Nov 25, 2019

With the .status file approach, the test now doesn't show up at all in the results for the debug build. I would have thought it would be green-on-pass/yellow-on-fail. I'm puzzled by that. It is showing up in non-debug builds as expected.

#30629 (comment)

@Trott
test: skip test-domain-error-types in debug mode temporariliy
6d022c1 
Until nodejs#30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: nodejs#30629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott merged commit 6d022c1 into nodejs:master Nov 26, 2019
@Trott
Copy link
Member Author

Trott commented Nov 26, 2019

Landed in 6d022c1

@Trott Trott deleted the skip-it branch November 26, 2019 18:20
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@Trott @addaleax
test: skip test-domain-error-types in debug mode temporariliy
70d6fa1 
Until #30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: #30629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@richardlau richardlau mentioned this pull request Dec 2, 2019
Closed
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Dec 23, 2019
@Trott @BethGriggs
test: skip test-domain-error-types in debug mode temporariliy
a83ccf8 
Until #30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: #30629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Dec 27, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
@Trott @BethGriggs
test: skip test-domain-error-types in debug mode temporariliy
49c6c37 
Until #30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: #30629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gengjiawen gengjiawen mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

+2 more reviewers

@rvagg rvagg rvagg left review comments

@lundibundi lundibundi lundibundi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott @nodejs-github-bot @richardlau @rvagg @addaleax @lundibundi