napi: implement napi_is_detached_arraybuffer

[lundibundi]

This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer.

Closes: #29955

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Also superseeds #30317.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/26886/

[devsnek]

section numbers tend to change, i'd just say "as defined in the ecmascript language specifiation."

[lundibundi]

This looks like a good idea but a lot of the other functions (in this doc) have links to the appropriate sections in the spec so I'm not sure.

[lundibundi]

Wow, another ICE here

https://ci.nodejs.org/job/node-test-commit-arm/nodes=debian9-docker-armv7/27580/console
debian9-docker-armv7

23:37:07 ../src/api/exceptions.cc: In function 'v8::Local<v8::Value> node::UVException(v8::Isolate*, int, const char*, const char*, const char*, const char*)':
23:37:07 ../src/api/exceptions.cc:146:53: internal compiler error: Segmentation fault
23:37:07    e->Set(env->context(), env->code_string(), js_code).Check();
23:37:07                                                      ^
23:37:07 Please submit a full bug report,
23:37:07 with preprocessed source if appropriate.
23:37:07 See <file:///usr/share/doc/gcc-6/README.Bugs> for instructions.
23:37:07 libnode.target.mk:330: recipe for target '/home/iojs/build/workspace/node-test-commit-arm/nodes/debian9-docker-armv7/out/Release/obj.target/libnode/src/api/exceptions.o' failed
23:37:07 make[2]: *** [/home/iojs/build/workspace/node-test-commit-arm/nodes/debian9-docker-armv7/out/Release/obj.target/libnode/src/api/exceptions.o] Error 1

/cc @addaleax

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/26916/

[legendecas]

Just found some nits in tests... 😅

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/26919/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/26924/

[lundibundi]

Well, the second ICE on the same machine

https://ci.nodejs.org/job/node-test-commit-arm/27606/nodes=debian9-docker-armv7/console
debian9-docker-armv7

17:38:16 ../src/node_v8.cc: In function 'void node::Initialize(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>, void*)':
17:38:16 ../src/node_v8.cc:175:57: internal compiler error: Segmentation fault
17:38:16                Uint32::NewFromUnsigned(env->isolate(), i)).Check();
17:38:16                                                          ^
17:38:16 ../src/node_v8.cc:51:3: note: in expansion of macro 'V'
17:38:16    V(2, total_physical_size, kTotalPhysicalSizeIndex)                          \
17:38:16    ^
17:38:16 ../src/node_v8.cc:177:3: note: in expansion of macro 'HEAP_STATISTICS_PROPERTIES'
17:38:16    HEAP_STATISTICS_PROPERTIES(V)
17:38:16    ^~~~~~~~~~~~~~~~~~~~~~~~~~
17:38:16 Please submit a full bug report,
17:38:16 with preprocessed source if appropriate.
17:38:16 See <file:///usr/share/doc/gcc-6/README.Bugs> for instructions.
17:38:16 libnode.target.mk:330: recipe for target '/home/iojs/build/workspace/node-test-commit-arm/nodes/debian9-docker-armv7/out/Release/obj.target/libnode/src/node_v8.o' failed
17:38:16 make[2]: *** [/home/iojs/build/workspace/node-test-commit-arm/nodes/debian9-docker-armv7/out/Release/obj.target/libnode/src/node_v8.o] Error 1
17:38:16 make[2]: *** Waiting for unfinished jobs....

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/26933/

[lundibundi]

Hm, ICE on debian9-docker-armv7 once again, not sure how to fix that.

22:57:02 ../src/node_v8.cc: In function 'void node::Initialize(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>, void*)':
22:57:02 ../src/node_v8.cc:169:59: internal compiler error: Segmentation fault
22:57:02                                 env->heap_statistics_buffer(),
22:57:02                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
22:57:02 Please submit a full bug report,
22:57:02 with preprocessed source if appropriate.
22:57:02 See <file:///usr/share/doc/gcc-6/README.Bugs> for instructions.
22:57:02 libnode.target.mk:330: recipe for target '/home/iojs/build/workspace/node-test-commit-arm/nodes/debian9-docker-armv7/out/Release/obj.target/libnode/src/node_v8.o' failed
22:57:02 make[2]: *** [/home/iojs/build/workspace/node-test-commit-arm/nodes/debian9-docker-armv7/out/Release/obj.target/libnode/src/node_v8.o] Error 1

/cc @nodejs/n-api @addaleax perhaps you can help?

[addaleax]

@lundibundi Somewhere @bnoordhuis suggested that those ICEs might be the result of an out-of-memory situation … I think it’s a machine that doesn’t have a ton of memory, so that might make sense?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/27082/

[mhdawson]

LGTM once my suggestion addition of the stability is added.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/27129/

[targos]

This needs a backport to land on v12.x-staging because V8 7.8 doesn't have ArrayBuffer::GetBackingStore