doc: document "Resume Build" limitation#30604
Merged
richardlau merged 1 commit intonodejs:masterfrom Nov 26, 2019
Merged
Conversation
Member
Author
BethGriggs
approved these changes
Nov 22, 2019
cjihrig
approved these changes
Nov 22, 2019
richardlau
added
the
author ready
addaleax
approved these changes
Nov 22, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Just for my understanding, if, say, only AIX failed, then this would not matter (even though it may be a good idea to start a fresh CI anyway)?
Member
Author
Yes, that's correct. I tried to keep the doc changes brief and simple. It is probably a good idea to start a new CI after seven days anyway to pick up changes in the branch being merged into. |
trivikr
approved these changes
Nov 22, 2019
Trott
reviewed
Nov 23, 2019
lpinca
approved these changes
Nov 23, 2019
Compiled binaries for fanned CI builds on Windows and ARM are only kept for seven days. PR-URL: nodejs#30604 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
force-pushed
the
collaborator
branch
from
bc1d94c to
f3a5097
Compare
Member
Author
|
Landed in f3a5097. |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Compiled binaries for fanned CI builds on Windows and ARM are only kept for seven days. PR-URL: #30604 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Compiled binaries for fanned CI builds on Windows and ARM are only kept for seven days. PR-URL: #30604 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Compiled binaries for fanned CI builds on Windows and ARM are only kept for seven days. PR-URL: #30604 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiled binaries for fanned CI builds on Windows and ARM are only kept
for seven days. Document that a fresh CI should be started if more than
seven days have elapsed since the original failing CI.
Refs: nodejs/build#1515 (comment)
cc @BethGriggs
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes