Refactor test-stream-writable-clear-buffer by Trott · Pull Request #30561 · nodejs/node

Trott · 2019-11-20T18:09:53Z

replace setTimeout() with setImmediate()

Replace setTimeout() with setImmediate() in
test-stream-writable-clear-buffer. The test still fails in Node.js 8.6.0
(if you comment out the common module, since it uses BigInts and those
aren't supported in 8.6.0).
use arrow function for anonymous callback
remove literal as message in assert.strictEqual()

This reveals the values that cause the assertion error, should it
happen.
move from sequential to parallel

I don't believe there's a reason test-stream-writable-clear-buffer needs
to be in sequential. Move it to parallel.

I tried to make it fail locally in parallel with tools/test.py -j 96 --repeat 192 test/parallel/test-stream-writable-clear-buffer.js but it passed and ran very quickly.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2019-11-20T18:10:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26792/

test/parallel/test-stream-writable-clear-buffer.js

addaleax

This doesn’t fix flakiness, does it? (Just asking because I’d be surprised if the test was flaky in its previous form)

test/parallel/test-stream-writable-clear-buffer.js

Trott · 2019-11-20T21:08:31Z

This doesn’t fix flakiness, does it? (Just asking because I’d be surprised if the test was flaky in its previous form)

No, it does not fix flakiness to my knowledge. It's just some improvements and getting it moved into parallel.

nodejs-github-bot · 2019-11-20T21:12:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26796/

nodejs-github-bot · 2019-11-22T11:00:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26843/

Replace setTimeout() with setImmediate() in test-stream-writable-clear-buffer. The test still fails in Node.js 8.6.0 (if you comment out the `common` module, since it uses BigInts and those aren't supported in 8.6.0). PR-URL: nodejs#30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: nodejs#30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

This reveals the values that cause the assertion error, should it happen. PR-URL: nodejs#30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

I don't believe there's a reason test-stream-writable-clear-buffer needs to be in sequential. Move it to parallel. PR-URL: nodejs#30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: nodejs#30561 (review) PR-URL: nodejs#30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: https://github.com/nodejs/node/pull/30561/files#r348667256 PR-URL: nodejs#30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Trott · 2019-11-22T19:42:27Z

Landed in b703218...19e44ef

Replace setTimeout() with setImmediate() in test-stream-writable-clear-buffer. The test still fails in Node.js 8.6.0 (if you comment out the `common` module, since it uses BigInts and those aren't supported in 8.6.0). PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

This reveals the values that cause the assertion error, should it happen. PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

I don't believe there's a reason test-stream-writable-clear-buffer needs to be in sequential. Move it to parallel. PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: #30561 (review) PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: https://github.com/nodejs/node/pull/30561/files#r348667256 PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Replace setTimeout() with setImmediate() in test-stream-writable-clear-buffer. The test still fails in Node.js 8.6.0 (if you comment out the `common` module, since it uses BigInts and those aren't supported in 8.6.0). PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

This reveals the values that cause the assertion error, should it happen. PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

I don't believe there's a reason test-stream-writable-clear-buffer needs to be in sequential. Move it to parallel. PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: #30561 (review) PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: https://github.com/nodejs/node/pull/30561/files#r348667256 PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Replace setTimeout() with setImmediate() in test-stream-writable-clear-buffer. The test still fails in Node.js 8.6.0 (if you comment out the `common` module, since it uses BigInts and those aren't supported in 8.6.0). PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

This reveals the values that cause the assertion error, should it happen. PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

I don't believe there's a reason test-stream-writable-clear-buffer needs to be in sequential. Move it to parallel. PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: #30561 (review) PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: https://github.com/nodejs/node/pull/30561/files#r348667256 PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 20, 2019

lundibundi approved these changes Nov 20, 2019

View reviewed changes

test/parallel/test-stream-writable-clear-buffer.js Outdated Show resolved Hide resolved

addaleax approved these changes Nov 20, 2019

View reviewed changes

test/parallel/test-stream-writable-clear-buffer.js Outdated Show resolved Hide resolved

Trott force-pushed the refactor-stream-test branch from affcba4 to e6d0107 Compare November 20, 2019 21:08

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 20, 2019

Trott added a commit to Trott/io.js that referenced this pull request Nov 22, 2019

test: use arrow function for callback in stream test

ac43427

PR-URL: nodejs#30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Trott closed this Nov 22, 2019

Trott force-pushed the refactor-stream-test branch from da7be1d to 19e44ef Compare November 22, 2019 19:44

Trott deleted the refactor-stream-test branch November 22, 2019 19:44

addaleax pushed a commit that referenced this pull request Nov 30, 2019

test: use arrow function for callback in stream test

ebba322

PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax pushed a commit that referenced this pull request Nov 30, 2019

test: move explanatory comment to expected location in file

106235f

Refs: #30561 (review) PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request Dec 1, 2019

test: use arrow function for callback in stream test

dd07ad4

PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request Dec 1, 2019

test: move explanatory comment to expected location in file

4dd0f5a

Refs: #30561 (review) PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

BridgeAR mentioned this pull request Dec 3, 2019

v13.3.0 proposal #30774

Merged

BethGriggs mentioned this pull request Dec 9, 2019

v12.13.2 proposal #30865

Closed

MylesBorins pushed a commit that referenced this pull request Dec 17, 2019

test: use arrow function for callback in stream test

59c9592

PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request Dec 17, 2019

test: move explanatory comment to expected location in file

516bdaf

Refs: #30561 (review) PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

BethGriggs mentioned this pull request Dec 23, 2019

v12.14.1 proposal #31069

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor test-stream-writable-clear-buffer#30561

Refactor test-stream-writable-clear-buffer#30561
Trott wants to merge 0 commit intonodejs:masterfrom
Trott:refactor-stream-test

Trott commented Nov 20, 2019

Uh oh!

nodejs-github-bot commented Nov 20, 2019

Uh oh!

Uh oh!

addaleax left a comment •

edited

Loading

Uh oh!

Uh oh!

Trott commented Nov 20, 2019

Uh oh!

nodejs-github-bot commented Nov 20, 2019

Uh oh!

nodejs-github-bot commented Nov 22, 2019

Uh oh!

Trott commented Nov 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Trott commented Nov 20, 2019

Checklist

Uh oh!

nodejs-github-bot commented Nov 20, 2019

Uh oh!

Uh oh!

addaleax left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Trott commented Nov 20, 2019

Uh oh!

nodejs-github-bot commented Nov 20, 2019

Uh oh!

nodejs-github-bot commented Nov 22, 2019

Uh oh!

Trott commented Nov 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

addaleax left a comment •

edited

Loading