Skip to content

[v10.x] n-api: correct bug in napi_get_last_error#30532

Closed
gabrielschulhof wants to merge 1 commit intonodejs:v10.x-stagingfrom
gabrielschulhof:backport-28702-to-v10.x
Closed

[v10.x] n-api: correct bug in napi_get_last_error#30532
gabrielschulhof wants to merge 1 commit intonodejs:v10.x-stagingfrom
gabrielschulhof:backport-28702-to-v10.x

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Nov 18, 2019

napi_get_last_error returns incorrect napi_status.

PR-URL: #28702
Reviewed-By: @jasnell
Reviewed-By: @gabrielschulhof
Reviewed-By: @cjihrig
Reviewed-By: @mhdawson

Re: #30487

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. v10.x labels Nov 18, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
mhdawson
mhdawson approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
n-api: correct bug in napi_get_last_error
d5a73ad 
napi_get_last_error returns incorrect napi_status.

PR-URL: nodejs#28702
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2019 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27301/ ✅

BethGriggs pushed a commit that referenced this pull request Dec 3, 2019
@BethGriggs
n-api: correct bug in napi_get_last_error
14e7a35 
napi_get_last_error returns incorrect napi_status.

Backport-PR-URL: #30532
PR-URL: #28702
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs
Copy link
Member

BethGriggs commented Dec 3, 2019

Landed in 14e7a35

@BethGriggs BethGriggs closed this Dec 3, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@MylesBorins
n-api: correct bug in napi_get_last_error
88e8b7c 
napi_get_last_error returns incorrect napi_status.

Backport-PR-URL: #30532
PR-URL: #28702
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof gabrielschulhof deleted the backport-28702-to-v10.x branch March 13, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gabrielschulhof @nodejs-github-bot @BethGriggs @legendecas @mhdawson