Conversation
referred to as readable.push several other times in transform documentation and also documented under readable, so makes sense to just stick with readable.push
nodejs-github-bot
added
doc
|
-1 I think it's more confusing this way as it looks more like a typo or copy and paste error. |
In that case, there are 3-4 places in that same section (implementing transform) where it is referred to as readable.push, so those should also be changed to transform.push... |
|
@nodejs/streams @nodejs/documentation @ronag PTAL |
|
I’m +-0. But I do agree it should be consistent one way or another. |
|
@mscdex do you still think this should not be changed? Or what would be your suggestion about having this consistent? |
|
@BridgeAR I'm fine with either leaving it as-is since it should be known that |
|
Ping @meelash |
|
@BridgeAR present |
|
Would you mind updating the doc as suggested by @mscdex? |
|
Ping @meelash |
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff to
2935f72
Compare
Consistency of method naming referred to as readable.push several other times in transform documentation and also documented under readable, so makes sense to just stick with readable.push PR-URL: #30506 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 1a9d631 |
Consistency of method naming referred to as readable.push several other times in transform documentation and also documented under readable, so makes sense to just stick with readable.push PR-URL: #30506 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Consistency of method naming referred to as readable.push several other times in transform documentation and also documented under readable, so makes sense to just stick with readable.push PR-URL: #30506 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Consistency of method naming referred to as readable.push several other times in transform documentation and also documented under readable, so makes sense to just stick with readable.push PR-URL: #30506 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
9 participants
referred to as readable.push several other times in transform documentation and also documented under readable, so makes sense to just stick with readable.push
Checklist