util: Use let instead of var for util/inspect.js#30399
Closed
lmammino wants to merge 3 commits intonodejs:masterfrom
Closed
util: Use let instead of var for util/inspect.js#30399lmammino wants to merge 3 commits intonodejs:masterfrom
lmammino wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
util
cjihrig
approved these changes
Nov 12, 2019
jasnell
approved these changes
Nov 12, 2019
jasnell
added
the
code-and-learn
trivikr
approved these changes
Nov 13, 2019
BridgeAR
approved these changes
Nov 13, 2019
BridgeAR
added
the
author ready
Member
Contributor
Author
|
Ci seems to be failing because the first letter (after subsystem) in my commit message is uppercase. I'll try to fix this with an amend commit... |
lmammino
force-pushed
the
fix/removes-var-from-inspect
branch
from
8c7a7df to
a2dd360
Compare
gireeshpunathil
approved these changes
Nov 16, 2019
Collaborator
Member
|
Linux-containered (ubuntu1804_sharedlibs_debug_x64): https://ci.nodejs.org/job/node-test-commit-linux-containered/16157/ |
Contributor
Author
|
Still seeing some failures in the CI, can someone guide me on what's wrong and how to resolve any pending issue? |
Member
|
last run (linux-containerized) was aborted due to infra issues. new run: |
Member
Member
|
the linux-containerized failure |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 26, 2019
PR-URL: #30399 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
landed in 3f59704. thanks for the contribution! |
Contributor
Author
|
Thank you all for helping me with this :) |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30399 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30399 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30399 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style changes: use
letinstead ofvarinlib/internal/util/inspect.jsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes