Skip to content

cluster: replace vars in child.js#30383

Closed
EmaSuriano wants to merge 2 commits intonodejs:masterfrom
EmaSuriano:cluster/child-removing-var
Closed

cluster: replace vars in child.js#30383
EmaSuriano wants to merge 2 commits intonodejs:masterfrom
EmaSuriano:cluster/child-removing-var

Conversation

@EmaSuriano
Copy link
Contributor

@EmaSuriano EmaSuriano commented Nov 12, 2019 •
edited
Loading

Code and Learn walkthrough ... change var to const

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the cluster Issues and PRs related to the cluster subsystem. label Nov 12, 2019
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Nov 13, 2019

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4072/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 16, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26613/

lundibundi
lundibundi suggested changes Nov 16, 2019
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ to make sure this doesn't accidentally get merged with other code&learn PRs considering it already has a few approvals, feel free to dismiss as soon as it's fixed.

@lundibundi lundibundi removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 16, 2019
@EmaSuriano @lundibundi
Update lib/internal/cluster/child.js
769746c 
Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26669/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 26, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27026/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 26, 2019

the failure in linux-containerized run node-api/test_make_callback/test-async-hooks-gcable is known as in #30648

gireeshpunathil pushed a commit that referenced this pull request Nov 26, 2019
@EmaSuriano @gireeshpunathil
cluster: replace vars in child.js
18ce3a3 
PR-URL: #30383
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 26, 2019

landed in 18ce3a3

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@EmaSuriano @addaleax
cluster: replace vars in child.js
378c54f 
PR-URL: #30383
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@EmaSuriano @targos
cluster: replace vars in child.js
a31ace5 
PR-URL: #30383
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@EmaSuriano @MylesBorins
cluster: replace vars in child.js
d70ec60 
PR-URL: #30383
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

+1 more reviewer

@lundibundi lundibundi lundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@EmaSuriano @BridgeAR @nodejs-github-bot @gireeshpunathil @jasnell @cjihrig @BethGriggs @lundibundi @trivikr