doc: remove "multiple variants" from BUILDING.md#30366
Merged
Trott merged 0 commit intonodejs:masterfrom Nov 14, 2019
Merged
Conversation
nodejs-github-bot
added
build
Contributor
|
s/one variants/one variant/ in commit message |
Member
Author
Thanks. Fixed. |
jasnell
approved these changes
Nov 12, 2019
lundibundi
approved these changes
Nov 12, 2019
devnexen
approved these changes
Nov 12, 2019
cjihrig
approved these changes
Nov 12, 2019
Trott
added
the
author ready
BridgeAR
approved these changes
Nov 13, 2019
Trott
force-pushed
the
multiple
branch
4 times, most recently
from
4946fbe to
86516c3
Compare
Member
Author
|
Landed in c71b89e |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
The statement that tests for tier 1 platforms are run on multiple variants is not true. We usually only run on one variant of macOS. Remove "multiple", which simplifies and clarifies the statements anyway. PR-URL: #30366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
The statement that tests for tier 1 platforms are run on multiple variants is not true. We usually only run on one variant of macOS. Remove "multiple", which simplifies and clarifies the statements anyway. PR-URL: #30366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
The statement that tests for tier 1 platforms are run on multiple variants is not true. We usually only run on one variant of macOS. Remove "multiple", which simplifies and clarifies the statements anyway. PR-URL: #30366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The statement that tests for tier 1 platforms are run on multiple
variants is not true. We usually only run on one variants of macOS.
Remove "multiple", which simplifies and clarifies the statements anyway.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes