test: Negative case for fs Dir class initialisation without handler#30313
Closed
Di9 wants to merge 1 commit intonodejs:masterfrom
Closed
test: Negative case for fs Dir class initialisation without handler#30313Di9 wants to merge 1 commit intonodejs:masterfrom
Di9 wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Nov 6, 2019
ChALkeR
added
the
code-and-learn
trivikr
approved these changes
Nov 6, 2019
Member
trivikr
left a comment
trivikr
left a comment
There was a problem hiding this comment.
The branch which this PR covers can be viewed here https://coverage.nodejs.org/coverage-b6201abacf36cc49/lib/internal/fs/dir.js.html#L39
BridgeAR
approved these changes
Nov 6, 2019
Di9
force-pushed
the
test-fs-dir-add
branch
2 times, most recently
from
67d5ee4 to
f08b7fd
Compare
gireeshpunathil
approved these changes
Nov 7, 2019
Collaborator
devnexen
approved these changes
Nov 7, 2019
lpinca
approved these changes
Nov 8, 2019
Covering the case when init Dir class without passing handle paramd to constructor.
jasnell
approved these changes
Nov 12, 2019
Collaborator
Collaborator
Member
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 26, 2019
Covering the case when init Dir class without passing handle paramd to constructor. PR-URL: #30313 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
landed in 8c41b19. thanks for the contribution! |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Covering the case when init Dir class without passing handle paramd to constructor. PR-URL: #30313 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Covering the case when init Dir class without passing handle paramd to constructor. PR-URL: #30313 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Covering the case when init Dir class without passing handle paramd to constructor. PR-URL: #30313 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covering the case when init Dir class without passing handler to constructor.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes