doc: fix up N-API doc

[mhdawson]

• Add missing N-API version info
• Fix N-API version info for napi_extended_error_info

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

[mhdawson]

@NickNaso let me know if I missed anything.

[NickNaso]

@mhdawson I think that you missed only napi_add_finalizer it's added in Node.js version 8.0.0 but it's promoted as stable in N-API version 5.

[NickNaso]

@mhdawson I found some other inconsistencies that I report below:

• Signature for napi_create_reference in documentation is:

NAPI_EXTERN napi_status napi_create_reference(napi_env env,
                                              napi_value value,
                                              int initial_refcount,
                                              napi_ref* result);

instead it should be:

NAPI_EXTERN napi_status napi_create_reference(napi_env env,
                                              napi_value value,
                                              uint32_t initial_refcount,
                                              napi_ref* result);

• Signature for napi_reference_ref in documentations is:

NAPI_EXTERN napi_status napi_reference_ref(napi_env env,
                                           napi_ref ref,
                                           int* result);

instead it should be:

NAPI_EXTERN napi_status napi_reference_ref(napi_env env,
                                           napi_ref ref,
                                           uint32_t* result);

• Signature for napi_reference_unref in documentation is:

NAPI_EXTERN napi_status napi_reference_unref(napi_env env,
                                             napi_ref ref,
                                             uint32_t* result);

• Signature for napi_call_function in documentations is:

napi_status napi_call_function(napi_env env,
                               napi_value recv,
                               napi_value func,
                               int argc,
                               const napi_value* argv,
                               napi_value* result)

instead it should be:

NAPI_EXTERN napi_status napi_call_function(napi_env env,
                                           napi_value recv,
                                           napi_value func,
                                           size_t argc,
                                           const napi_value* argv,
                                           napi_value* result);

• Signature for napi_make_callback in documentations is:

napi_status napi_make_callback(napi_env env,
                               napi_async_context async_context,
                               napi_value recv,
                               napi_value func,
                               int argc,
                               const napi_value* argv,
                               napi_value* result)

instead it should be:

NAPI_EXTERN napi_status napi_make_callback(napi_env env,
                                           napi_async_context async_context,
                                           napi_value recv,
                                           napi_value func,
                                           size_t argc,
                                           const napi_value* argv,
                                           napi_value* result);

I think that we could avoid to open other PR and handle the necessary changes in this one.

[BridgeAR]

RSLGTM

[mhdawson]

@NickNaso thanks I'll look at the non-version related inconsistencies separately.

EDIT, I see the comment above, will integrate into this PR.

[mhdawson]

@NickNaso napi_add_finalizer was already tagged as version 5 that is why it does not show up in the diffs.

[mhdawson]

@NickNaso addressed the rest of the comments

[NickNaso]

LGTM

[mhdawson]

Lite CI run: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4032/

[trivikr]

Landed in 1e0679e