Skip to content

doc: move inactive Collaborators to emeriti#30243

Merged
Trott merged 0 commit intonodejs:masterfrom
Trott:emeriti-2
Nov 6, 2019
Merged

doc: move inactive Collaborators to emeriti#30243
Trott merged 0 commit intonodejs:masterfrom
Trott:emeriti-2

Conversation

@Trott
Copy link
Member

@Trott Trott commented Nov 4, 2019

Move a handful of inactive Collaborators to emeriti.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 4, 2019
@Trott
Copy link
Member Author

Trott commented Nov 4, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4028/

@trivikr
Copy link
Member

trivikr commented Nov 4, 2019

Last activity for collaborators:

I think @RReverser should not be moved to emeriti

@trivikr trivikr mentioned this pull request Nov 4, 2019
Closed
@Trott
Copy link
Member Author

Trott commented Nov 4, 2019

I think @RReverser should not be moved to emeriti

Based on my email exchange with RReverser prior to opening this PR, they disagree with that assessment and think they should be moved to emeritus. That said, I'm happy to pull them out of this PR if they are having second thoughts.

@trivikr
Copy link
Member

trivikr commented Nov 4, 2019

Based on my email exchange with RReverser prior to opening this PR, they disagree with that assessment and think they should be moved to emeritus.

I didn't have conversation with RReverser, my suggestion was solely based on activity. They can be moved to emeritus.

@Trott
Copy link
Member Author

Trott commented Nov 4, 2019

Based on my email exchange with RReverser prior to opening this PR, they disagree with that assessment and think they should be moved to emeritus.

I didn't have conversation with RReverser, my suggestion was solely based on activity. They can be moved to emeritus.

Sounds good. In light of relatively recent comments from them, I just want to give them the opportunity to say "You know what, keep me around, I want to be able to use my comments to approve/reject changes" or whatever. But yeah, if we don't hear otherwise, let's land this as-is.

mhdawson
mhdawson approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 5, 2019
benjamingr
benjamingr approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :]

@Trott Trott closed this Nov 6, 2019
@Trott
Copy link
Member Author

Trott commented Nov 6, 2019

Landed in b6201ab

@Trott Trott merged commit b6201ab into nodejs:master Nov 6, 2019
@brendanashworth
Copy link
Contributor

brendanashworth commented Nov 8, 2019

Thank you!

MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@Trott @MylesBorins
doc: move inactive Collaborators to emeriti
15a7032 
Move a handful of inactive Collaborators to emeriti.

PR-URL: #30243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@Trott @targos
doc: move inactive Collaborators to emeriti
557ad1a 
Move a handful of inactive Collaborators to emeriti.

PR-URL: #30243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Trott @MylesBorins
doc: move inactive Collaborators to emeriti
f66f28e 
Move a handful of inactive Collaborators to emeriti.

PR-URL: #30243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
@Trott Trott deleted the emeriti-2 branch January 20, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.