buffer: improve performance caused by primordials by jizusun · Pull Request #30235 · nodejs/node

jizusun · 2019-11-03T12:10:24Z

This is my first try, and it's based on the code-and-learn guidances
This restore some performance after introducing primordialias.

Benchmark compared with master version using the methods mentioned here

Perf Comparison

                                                                                confidence improvement accuracy (*)    (**)   (***)
 buffers/buffer-compare-offset.js n=1000000 size=16 method='offset'                            -2.56 %       ±5.19%  ±6.93%  ±9.07%
 buffers/buffer-compare-offset.js n=1000000 size=16 method='slice'                     ***     17.14 %       ±4.95%  ±6.60%  ±8.60%
 buffers/buffer-compare-offset.js n=1000000 size=16386 method='offset'                         -1.76 %       ±4.77%  ±6.35%  ±8.26%
 buffers/buffer-compare-offset.js n=1000000 size=16386 method='slice'                  ***     21.40 %       ±6.61%  ±8.81% ±11.50%
 buffers/buffer-compare-offset.js n=1000000 size=4096 method='offset'                           1.69 %       ±5.34%  ±7.12%  ±9.28%
 buffers/buffer-compare-offset.js n=1000000 size=4096 method='slice'                   ***     20.82 %       ±5.64%  ±7.52%  ±9.84%
 buffers/buffer-compare-offset.js n=1000000 size=512 method='offset'                           -1.59 %       ±5.90%  ±7.86% ±10.26%
 buffers/buffer-compare-offset.js n=1000000 size=512 method='slice'                    ***     20.01 %       ±4.67%  ±6.22%  ±8.10%

Refs: #29766
Refs: nodejs/code-and-learn#97
Refs: #29633

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

This is my first PR, and it's based on the code-and-learn guidances This restore some performance after introducing primordialias. Fixes: nodejs#29766 Refs: nodejs/code-and-learn#97 Refs: nodejs#29633

addaleax · 2019-11-03T12:18:51Z

lib/buffer.js

 'use strict';

-const { Math, Object } = primordials;
+const { Object: { defineProperties, defineProperty, setPrototypeOf, create } } = primordials;


Did you run make lint? It would usually complain about a line longer than 80 characters.

Good afternoon 😃
Oh what a quick feedback!
Thank you♥️
I'll fix it when I'm back home.

One more thing to ask for help, what's the correct way to do prettify? Normally I have prettier set up with eslint, but I didn't find similar in the Makefile.

make lint-js-fix :)

Oh I mean, for the max-len rule, the eslint --fix cannot help.
So I have to correct it by myself, right?

jizusun · 2019-11-03T13:14:52Z

I think I also need to include a benchmark section to make my first PR better 😏 , but I don't have time today.
I'll dive deep into it tomorrow.

benchmark attached

lib/buffer.js

legendecas

LGTM % one nit in comments.

lib/buffer.js

nodejs-github-bot · 2019-11-04T04:37:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26304/

jizusun · 2019-11-04T07:11:57Z

Dear all reviewers,

I saw the several builds fails in Jenkins, and one build node-test-commit-freefsd fails because

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

Do you think it's because of my change or the job is not stable (ignore it / re-trigger it)?

nodejs-github-bot · 2019-11-04T07:36:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26310/

gireeshpunathil · 2019-11-04T07:51:56Z

@jizusun - we have seen that earlier and reported in #29802 , so don't worry about that.

This is my first PR, and it's based on the code-and-learn guidances This restore some performance after introducing primordialias. Refs: #29766 Refs: nodejs/code-and-learn#97 Refs: #29633 PR-URL: #30235 Refs: #29766 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

ZYSzys · 2019-11-04T13:28:11Z

Landed in 22799be.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

This is my first PR, and it's based on the code-and-learn guidances This restore some performance after introducing primordialias. Refs: #29766 Refs: nodejs/code-and-learn#97 Refs: #29633 PR-URL: #30235 Refs: #29766 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

buffer: improve performance caused by primordials

3a7c798

This is my first PR, and it's based on the code-and-learn guidances This restore some performance after introducing primordialias. Fixes: nodejs#29766 Refs: nodejs/code-and-learn#97 Refs: nodejs#29633

nodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Nov 3, 2019

jizusun mentioned this pull request Nov 3, 2019

event: improve performance of EventEmitter.emit #29633

Closed

2 tasks

addaleax reviewed Nov 3, 2019

View reviewed changes

buffer: fix lint error

0a1d464

jizusun force-pushed the code-learn-20191103 branch from 61292fa to 0a1d464 Compare November 3, 2019 12:58

jizusun mentioned this pull request Nov 3, 2019

Performance regression in v12 caused by primordials #29766

Closed

gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 3, 2019

gireeshpunathil approved these changes Nov 3, 2019

View reviewed changes

legendecas approved these changes Nov 3, 2019

View reviewed changes

devnexen approved these changes Nov 3, 2019

View reviewed changes

addaleax approved these changes Nov 3, 2019

View reviewed changes

lib/buffer.js Outdated Show resolved Hide resolved

ZYSzys approved these changes Nov 3, 2019

View reviewed changes

trivikr approved these changes Nov 3, 2019

View reviewed changes

legendecas approved these changes Nov 4, 2019

View reviewed changes

lib/buffer.js Outdated Show resolved Hide resolved

chore: more explicit names

d04e6d8

jizusun force-pushed the code-learn-20191103 branch from ba61692 to d04e6d8 Compare November 4, 2019 03:50

legendecas approved these changes Nov 4, 2019

View reviewed changes

ZYSzys closed this Nov 4, 2019

targos mentioned this pull request Nov 5, 2019

v13.1.0 release proposal #30262

Merged

targos mentioned this pull request Nov 10, 2019

v12.13.1 release proposal #30352

Merged

Uh oh!

Conversation

jizusun commented Nov 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

addaleax Nov 3, 2019

Choose a reason for hiding this comment

Uh oh!

jizusun Nov 3, 2019

Choose a reason for hiding this comment

Uh oh!

jizusun Nov 3, 2019

Choose a reason for hiding this comment

Uh oh!

addaleax Nov 3, 2019

Choose a reason for hiding this comment

Uh oh!

jizusun Nov 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jizusun commented Nov 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

legendecas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 4, 2019

Uh oh!

jizusun commented Nov 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 4, 2019

Uh oh!

gireeshpunathil commented Nov 4, 2019

Uh oh!

ZYSzys commented Nov 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jizusun commented Nov 3, 2019 •

edited

Loading

jizusun Nov 4, 2019 •

edited

Loading

jizusun commented Nov 3, 2019 •

edited

Loading

legendecas left a comment •

edited

Loading

jizusun commented Nov 4, 2019 •

edited

Loading