doc: improve doc Http2Stream:Aborted#30179
doc: improve doc Http2Stream:Aborted#30179dev-script wants to merge 1 commit intonodejs:masterfrom dev-script:docs/http2-event-aborted
Conversation
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Fixes: nodejs/help#877
|
@dev-313 - if you are planning to attack all of those pending |
|
Okay @gireeshpunathil . Thanks |
|
@nodejs/build - can you please review https://ci.nodejs.org/job/node-linter/3957/console and advise what is going on? does not look like a normal build failure to me. |
@rvagg I think this is related to nodejs/build#2012 (comment). The sh "curl -L -s https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh -s | bash -xe"which calls https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh 01:40:36 + curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh
01:40:36 + bash -ex -s before
01:40:36 % Total % Received % Xferd Average Speed Time Time Time Current
01:40:36 Dload Upload Total Spent Left Speed
01:40:37
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 985 100 985 0 0 3315 0 --:--:-- --:--:-- --:--:-- 3327
01:40:37 + set +x
01:40:37 bash: line 9: /jenkins_diagnostics.txt: Permission deniedsuggesting |
|
Yes, and I can't work out why |
|
I've restored the old FreeBSD servers while we figure this one out. These pipeline builds are the worst for debugging, I've got no idea where |
|
Got this sorted out, it was a configuration weirdness specific to the machine that has the most likelihood of being chosen for this task nodejs/build#2021, it's now back off FreeBSD. |
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
landed as 8b53d0b |
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.
Fixes: nodejs/help#877
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes