fix some typos inside the configure script#3016
Closed
pmq20 wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Contributor
pmq20
commented
Sep 23, 2015
pmq20
commented
- reglar -> regular
- is -> are
- comment on the right indent level on "Need llvm_version..."
pmq20
force-pushed
the
minqi-pan-sep-23-2
branch
2 times, most recently
from
85ed176 to
1df40f3
Compare
Member
|
Changes LGTM. |
pmq20
force-pushed
the
minqi-pan-sep-23-2
branch
from
1df40f3 to
c321e2f
Compare
pmq20
changed the title
Contributor
Author
|
changed commit message to "build" as subsystem. |
Contributor
|
LGTM |
silverwind
pushed a commit
that referenced
this pull request
Sep 23, 2015
PR-URL: #3016 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Contributor
|
Thanks, landed in d0d4877. |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 25, 2015
PR-URL: #3016 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Sep 30, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.