Skip to content

doc: sort bottom-of-the-page references#30124

Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof:order-napi-doc-refs
Closed

doc: sort bottom-of-the-page references#30124
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof:order-napi-doc-refs

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Oct 25, 2019

Use tail -n 102 doc/api/n-api.md | LC_ALL=C sort -u to establish a
systematic order for the references.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Oct 25, 2019
doc,n-api: sort bottom-of-the-page references
8a07d7f 
Use `tail -n 102 doc/api/n-api.md | LC_ALL=C sort -u` to establish a
systematic order for the references.
@legendecas
Copy link
Member

legendecas commented Oct 26, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4009/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2019
@gabrielschulhof gabrielschulhof added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 26, 2019
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Oct 26, 2019

May I have a +1s for fast-tracking?

gabrielschulhof pushed a commit that referenced this pull request Oct 26, 2019
doc,n-api: sort bottom-of-the-page references
df629c0 
Use `tail -n 102 doc/api/n-api.md | LC_ALL=C sort -u` to establish a
systematic order for the references.

PR-URL: #30124
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: legendecas <legendecas@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Oct 26, 2019

Closed in df629c0.

@gabrielschulhof gabrielschulhof deleted the order-napi-doc-refs branch October 27, 2019 01:44
targos pushed a commit that referenced this pull request Oct 28, 2019
@targos
doc,n-api: sort bottom-of-the-page references
32a5389 
Use `tail -n 102 doc/api/n-api.md | LC_ALL=C sort -u` to establish a
systematic order for the references.

PR-URL: #30124
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: legendecas <legendecas@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@targos
doc,n-api: sort bottom-of-the-page references
4ed13dc 
Use `tail -n 102 doc/api/n-api.md | LC_ALL=C sort -u` to establish a
systematic order for the references.

PR-URL: #30124
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: legendecas <legendecas@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@targos
doc,n-api: sort bottom-of-the-page references
b53a980 
Use `tail -n 102 doc/api/n-api.md | LC_ALL=C sort -u` to establish a
systematic order for the references.

PR-URL: #30124
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: legendecas <legendecas@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@targos
doc,n-api: sort bottom-of-the-page references
8a7ead3 
Use `tail -n 102 doc/api/n-api.md | LC_ALL=C sort -u` to establish a
systematic order for the references.

PR-URL: #30124
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: legendecas <legendecas@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@targos
doc,n-api: sort bottom-of-the-page references
0ec63ee 
Use `tail -n 102 doc/api/n-api.md | LC_ALL=C sort -u` to establish a
systematic order for the references.

PR-URL: #30124
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: legendecas <legendecas@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gabrielschulhof @legendecas @jasnell @cjihrig @richardlau @trivikr @nodejs-github-bot