Skip to content

doc: fix --enable-source-maps flag in v12.12.0 changelog#29960

Closed
TheUnlocked wants to merge 1 commit intonodejs:masterfrom
TheUnlocked:patch-1
Closed

doc: fix --enable-source-maps flag in v12.12.0 changelog#29960
TheUnlocked wants to merge 1 commit intonodejs:masterfrom
TheUnlocked:patch-1

Conversation

@TheUnlocked
Copy link
Contributor

@TheUnlocked TheUnlocked commented Oct 14, 2019

Resolves #29959

@TheUnlocked
Resolves nodejs#29959
c3eea4c 
Corrects "--source-map-support" to "--enable-source-maps"
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 14, 2019
@Trott Trott requested a review from bcoe October 14, 2019 02:07
@Trott Trott mentioned this pull request Oct 14, 2019
Merged
@BridgeAR BridgeAR changed the title Correct "--source-map-support" to "--enable-source-maps" in v12.12.0 changelog doc: fix --enable-source-maps flag in v12.12.0 changelog Oct 14, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Oct 14, 2019

Please upvote to fast-track.

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 14, 2019
@addaleax
Copy link
Member

addaleax commented Oct 14, 2019

Landed in c625039

@addaleax addaleax closed this Oct 14, 2019
addaleax pushed a commit that referenced this pull request Oct 14, 2019
@TheUnlocked @addaleax
doc: fix --enable-source-maps flag in v12.12.0 changelog
c625039 
Corrects "--source-map-support" to "--enable-source-maps".

Fixes: #29959
PR-URL: #29960
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Oct 14, 2019
@TheUnlocked @targos
doc: fix --enable-source-maps flag in v12.12.0 changelog
1dde617 
Corrects "--source-map-support" to "--enable-source-maps".

Fixes: #29959
PR-URL: #29960
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Oct 15, 2019
Merged
@addaleax addaleax added the source maps Issues and PRs related to source map support. label Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@bcoe bcoe Awaiting requested review from bcoe

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. source maps Issues and PRs related to source map support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CHANGELOG_V12 - wrong flag listed

7 participants

@TheUnlocked @BridgeAR @addaleax @Trott @targos @BethGriggs @nodejs-github-bot