module: warn on require of .js inside type: module#29909
Closed
guybedford wants to merge 3 commits intonodejs:masterfrom
Closed
module: warn on require of .js inside type: module#29909guybedford wants to merge 3 commits intonodejs:masterfrom
guybedford wants to merge 3 commits intonodejs:masterfrom
Conversation
BridgeAR
approved these changes
Oct 10, 2019
cjihrig
approved these changes
Oct 10, 2019
ZYSzys
reviewed
Oct 10, 2019
dba91d0 to
38554bc
Compare
4 tasks
Collaborator
38554bc to
9153981
Compare
Collaborator
2 tasks
Contributor
|
Revised message SGTM! |
guybedford
added a commit
that referenced
this pull request
Oct 11, 2019
PR-URL: #29909 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in aca1c28. |
targos
pushed a commit
that referenced
this pull request
Nov 8, 2019
PR-URL: #29909 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
PR-URL: #29909 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the PR made in #29732 ensuring a warning is emitted when violating the "type": "module" expected module format.
This was discussed at today's modules group meeting as a starting point for handling this case, and then whether or not an error will be thrown when modules are unflagged is still to be discussed further.
Example output:
@nodejs/modules-active-members
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes