fs: remove options.encoding from Dir.read*()#29908
Closed
Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Closed
fs: remove options.encoding from Dir.read*()#29908Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Conversation
Fishrock123
added
fs
Contributor
Author
|
Upvote to fast-track. |
cjihrig
approved these changes
Oct 9, 2019
addaleax
approved these changes
Oct 9, 2019
BridgeAR
approved these changes
Oct 9, 2019
Fishrock123
force-pushed
the
fs-readdir-no-read-encoding
branch
from
715bf2c to
114e101
Compare
This is unlikely to be necessary in any case, and causes much unwarrented complexity when implementing further optimizations. Refs: nodejs#29893 (comment)
Fishrock123
force-pushed
the
fs-readdir-no-read-encoding
branch
from
114e101 to
c83ca71
Compare
Contributor
Author
Fishrock123
added a commit
that referenced
this pull request
Oct 9, 2019
This is unlikely to be necessary in any case, and causes much unwarrented complexity when implementing further optimizations. Refs: #29893 (comment) PR-URL: #29908 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
Author
|
Landed in 7f22aaf |
Contributor
Author
|
To be clear, this is not semver-major as the |
3 tasks
BridgeAR
pushed a commit
that referenced
this pull request
Oct 10, 2019
This is unlikely to be necessary in any case, and causes much unwarrented complexity when implementing further optimizations. Refs: #29893 (comment) PR-URL: #29908 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had implemented it 'just in case' but in #29893 it occurs to me that this is likely not a good idea and this functionality should not be released if possible.
This is unlikely to be necessary in any case, and causes much unwarranted complexity when implementing further optimizations.
i.e. if you really need multiple encodings, you're probably better off reading the whole thing more than once. Or, if someone really does come along with an actual compelling use case then we can reconsider.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes