doc: return type is number#29828
Closed
exoego wants to merge 1 commit intonodejs:masterfrom
exoego:http2-doc
Closed
doc: return type is number#29828exoego wants to merge 1 commit intonodejs:masterfrom exoego:http2-doc
exoego wants to merge 1 commit intonodejs:masterfrom
exoego:http2-doc
Conversation
nodejs-github-bot
added
doc
Trott
reviewed
Oct 3, 2019
| * `localClose` {number} `true` if this `Http2Stream` has been closed locally. | ||
| * `remoteClose` {number} `true` if this `Http2Stream` has been closed | ||
| * `localClose` {number} `1` if this `Http2Stream` has been closed locally. | ||
| * `remoteClose` {number} `1` if this `Http2Stream` has been closed |
Member
There was a problem hiding this comment.
If I'm reading the nghttp2 source correctly, it's 1 if remote peer half closed the given stream, 0 if it did not, and -1 if no such stream exists. Same for localClose. Is it possible to get -1 for these properties in Node.js?
Once the possible values are determined, tests should be augmented to check those values are returned in the expected situations. That doesn't have to happen in this PR but it would be a nice addition for sure.
Trott
approved these changes
Oct 11, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Despite my suggested improvement, this is an improvement as it is already so I'm going to land it. My additional suggestions can happen some other time (or not).
This comment has been minimized.
This comment has been minimized.
Member
Member
|
Landed in 3aeae8d |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 11, 2019
PR-URL: nodejs#29828 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 14, 2019
PR-URL: #29828 Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node/test/parallel/test-http2-session-stream-state.js
Lines 22 to 23 in 88ef086
Type of
localCloseandremoteClosearenumber, so I think1is valid instead oftrue.Checklist