src: disconnect inspector before exiting out of fatal exception by joyeecheung · Pull Request #29611 · nodejs/node

joyeecheung · 2019-09-19T02:45:31Z

So that coverage, .etc are properly written in case of a normal
fatal exception.

Fixes: #29570

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

So that coverage, .etc are properly written in case of a normal fatal exception.

joyeecheung · 2019-09-19T02:45:48Z

cc @bcoe @addaleax

nodejs-github-bot · 2019-09-19T02:46:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25562/

joyeecheung · 2019-09-19T05:14:09Z

src/node_errors.cc


  // Now we are certain that the exception is fatal.
  ReportFatalException(env, error, message, EnhanceFatalException::kEnhance);
+  WaitForInspectorDisconnect(env);


I didn't leave this for other Exit() calls in TriggerUncaughtException() as those cases are more abnormal than this (e.g. the global uncaught exception handler throws itself, or the global hook is monkey-pached incorrectly) and I think it would unsafe to wait until the inspector shut down in those cases.

joyeecheung · 2019-09-19T05:24:04Z

src/node_errors.cc

  // Now we are certain that the exception is fatal.
  ReportFatalException(env, error, message, EnhanceFatalException::kEnhance);
+#if HAVE_INSPECTOR
+  profiler::EndStartedProfilers(env);


Uh just realized we should call profiler::EndStartedProfilers instead since the whole WaitForInspectorDisconnect resets signals.

patilharshal16 · 2019-09-19T11:17:58Z

test/fixtures/v8-coverage/throw.js

@@ -0,0 +1,7 @@
+const a = 99;
+if (true) {


no point of adding else block

This is in the test though?

bcoe

One little nit with regards to test name 😄

Thanks for digging into this, I thought it would be something obvious.

bcoe · 2019-09-19T15:11:53Z

test/parallel/test-v8-coverage.js

  assert.strictEqual(fixtureCoverage.functions[0].ranges[1].count, 0);
 }

+// Outputs coverage when process.exit(1) exits process.


perhaps, change to:

// Outputs coverage when error is thrown in first tick.

Uh thanks for catching my copy-past error :)

…xception

nodejs-github-bot · 2019-09-20T01:11:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25590/

Trott · 2019-09-24T06:21:59Z

@joyeecheung This is ready to land in your opinion?

joyeecheung · 2019-09-24T13:40:14Z

@Trott yes

So that coverage, .etc are properly written in case of a normal fatal exception. PR-URL: nodejs#29611 Fixes: nodejs#29570 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com>

bcoe · 2019-09-24T16:57:33Z

Landed in b263423

So that coverage, .etc are properly written in case of a normal fatal exception. PR-URL: #29611 Fixes: #29570 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com>

src: disconnect inspector before exiting out of fatal exception

83fc7ad

So that coverage, .etc are properly written in case of a normal fatal exception.

joyeecheung force-pushed the fix-coverage-throw branch from 1da18a1 to 83fc7ad Compare September 19, 2019 02:45

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 19, 2019

joyeecheung added errors Issues and PRs related to JavaScript errors originated in Node.js core. coverage Issues and PRs related to native coverage support. labels Sep 19, 2019

joyeecheung commented Sep 19, 2019

View reviewed changes

fixup! src: disconnect inspector before exiting out of fatal exception

35b3eb9

joyeecheung commented Sep 19, 2019

View reviewed changes

patilharshal16 reviewed Sep 19, 2019

View reviewed changes

cjihrig approved these changes Sep 19, 2019

View reviewed changes

devnexen approved these changes Sep 19, 2019

View reviewed changes

bcoe suggested changes Sep 19, 2019

View reviewed changes

fixup! fixup! src: disconnect inspector before exiting out of fatal e…

07c3ae3

…xception

joyeecheung force-pushed the fix-coverage-throw branch from a85298b to 07c3ae3 Compare September 20, 2019 01:11

bcoe approved these changes Sep 22, 2019

View reviewed changes

danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 23, 2019

bcoe closed this Sep 24, 2019

targos mentioned this pull request Oct 1, 2019

v12.11.1 release proposal #29796

Merged

beevelop mentioned this pull request Oct 1, 2019

2019-10-01 Version 12.11.1 (Current) @targos beevelop/docker-nodejs#304

Closed

Uh oh!

Conversation

joyeecheung commented Sep 19, 2019

Checklist

Uh oh!

joyeecheung commented Sep 19, 2019

Uh oh!

nodejs-github-bot commented Sep 19, 2019

Uh oh!

joyeecheung Sep 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joyeecheung Sep 19, 2019

Choose a reason for hiding this comment

Uh oh!

patilharshal16 Sep 19, 2019

Choose a reason for hiding this comment

Uh oh!

joyeecheung Sep 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bcoe left a comment

Choose a reason for hiding this comment

Uh oh!

bcoe Sep 19, 2019

Choose a reason for hiding this comment

Uh oh!

joyeecheung Sep 20, 2019

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 20, 2019

Uh oh!

Trott commented Sep 24, 2019

Uh oh!

joyeecheung commented Sep 24, 2019

Uh oh!

bcoe commented Sep 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

joyeecheung Sep 19, 2019 •

edited

Loading

joyeecheung Sep 19, 2019 •

edited

Loading