tools: fix iculslocs to support ICU 65.1

[srl295]

The internal ICU alias table format changed in ICU 65.1: ICU-20627

Because of this, iculslocs.cc needs to handle URES_TABLE format
contents in the res_index.txt file.

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[srl295]

not super urgent but the 65.1 RC will be out soonish.

[mhdawson]

LGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/25453/

[srl295]

^ help please, i can't find the failing CI logs…

[ryzokuken]

Thanks!

[ryzokuken]

@srl295 https://ci.nodejs.org/job/node-test-binary-windows-2/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/2994/console

23:49:32 not ok 123 parallel/test-child-process-fork-exec-path
23:49:32   ---
23:49:32   duration_ms: 0.498
23:49:32   severity: fail
23:49:32   exitcode: 1
23:49:32   stack: |-
23:49:32     Can't clean tmpdir: c:\workspace\node-test-binary-windows-2\test\.tmp.123
23:49:32     Files blocking: []
23:49:32     
23:49:32     c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:136
23:49:32         throw e;
23:49:32         ^
23:49:32     
23:49:32     Error: ENOTEMPTY: directory not empty, rmdir 'c:\workspace\node-test-binary-windows-2\test\.tmp.123'
23:49:32         at Object.rmdirSync (fs.js:779:3)
23:49:32         at rmdirSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:86:10)
23:49:32         at rimrafSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:41:7)
23:49:32         at process.onexit (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:121:5)
23:49:32         at process.emit (events.js:214:15) {
23:49:32       errno: -4051,
23:49:32       syscall: 'rmdir',
23:49:32       code: 'ENOTEMPTY',
23:49:32       path: 'c:\\workspace\\node-test-binary-windows-2\\test\\.tmp.123'
23:49:32     }
23:49:32   ...

[srl295]

@srl295 https://ci.nodejs.org/job/node-test-binary-windows-2/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/2994/console

23:49:32 Can't clean tmpdir: c:\workspace\node-test-binary-windows-2\test.tmp.123
23:49:32 Files blocking: []

should've used rimraf 😅

OK, is this a blocker or should I land this? ICU 65.1 RC is out now, so this will start to hit…

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/25457/

[srl295]

Landed in fa6839e