deps: V8: cherry-pick 35c6d4d

[cclauss]

Original commit message:

Make code generator python3.7 compatible (async keyword).

Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: #29326

[sam-github]

I agree we should backport, @targos @bnoordhuis , do you?

@cclauss We have a tool for v8 backports that ensures consistent process. npm i -g node-core-utils; ncu-config set branch master; ncu-config set upstream upstream; git node v8 backport Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109. Would you like to try, or shall I?

I'll need a link to what to backport. The 2 SHAs mentioned here aren't working for me, even when I remove the leading "I":

core/node (master $% u=) % git node v8 backport Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109                                                                                    
  ✔ Update local V8 clone
  ❯ V8 commit backport
    ✔ Get current V8 version
    ✖ Generate patches
      → 'git <command> [<revision>...] -- [<file>...]'
      Apply and commit patches to deps/v8
✖ fatal: ambiguous argument 'Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

core/node (master $% u=) % git node v8 backport fcd8b8cb1de60a007c7bbd4564d7869e83cb7109 
  ✔ Update local V8 clone
  ❯ V8 commit backport
    ✔ Get current V8 version
    ✖ Generate patches
      → 'git <command> [<revision>...] -- [<file>...]'
      Apply and commit patches to deps/v8
✖ fatal: ambiguous argument 'fcd8b8cb1de60a007c7bbd4564d7869e83cb7109^..fcd8b8cb1de60a007c7bbd4564d7869e83cb7109': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

core/node (master $% u=) % git node v8 backport 35c6d4d                                 
  ✔ Update local V8 clone
  ❯ V8 commit backport
    ✔ Get current V8 version
    ✖ Generate patches
      → 'git <command> [<revision>...] -- [<file>...]'
      Apply and commit patches to deps/v8
✖ fatal: ambiguous argument '35c6d4d': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

[cclauss]

Thanks Sam -- please go ahead with the tool-based approach.

https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351 is what we are trying to backport.

Ben’s request that we fix Google’s code first and then backport is at #29346 (comment)

Targos’ commitment to do so in that order is at #29340 (comment)

Closing now in favor of your effort.

[sam-github]

@targos every try I've made has failed so far, any idea what I'm doing wrong? I'm trying to backport https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351

core/node (master $% u=) % git node v8 backport https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
  ✔ Update local V8 clone
  ❯ V8 commit backport
    ✔ Get current V8 version
    ✖ Generate patches
      → fatal: Invalid object name 'https'.
      Apply and commit patches to deps/v8
✖ fatal: Invalid object name 'https'.

core/node (master $% u=) % git node v8 backport 35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a                                    
  ✔ Update local V8 clone
  ❯ V8 commit backport
    ✔ Get current V8 version
    ✖ Generate patches
      → 'git <command> [<revision>...] -- [<file>...]'
      Apply and commit patches to deps/v8
✖ fatal: ambiguous argument '35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a^..35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

core/node (master $% u=) % git node v8 backport 3fdaf21204b8a2bbaf12e7509031209eeff4b971
  ✔ Update local V8 clone
  ❯ V8 commit backport
    ✔ Get current V8 version
    ✖ Generate patches
      → 'git <command> [<revision>...] -- [<file>...]'
      Apply and commit patches to deps/v8
✖ fatal: ambiguous argument '3fdaf21204b8a2bbaf12e7509031209eeff4b971^..3fdaf21204b8a2bbaf12e7509031209eeff4b971': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

core/node (master $% u=) % git node v8 backport         35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a
  ✔ Update local V8 clone
  ❯ V8 commit backport
    ✔ Get current V8 version
    ✖ Generate patches
      → 'git <command> [<revision>...] -- [<file>...]'
      Apply and commit patches to deps/v8
✖ fatal: ambiguous argument '35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a^..35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

[targos]

@sam-github you can't use the tool because the commit isn't in the V8 repository.
I'm +1 on floating it before V8 ugrades its dependency.