doc: update N-API version matrix#29461
Conversation
nodejs-github-bot
added
doc
doc/api/n-api.md
Outdated
There was a problem hiding this comment.
Should these all be REPLACME ? I know we use that normally for when versions need to inserted but I think that might make sense for only master, which is not listed in the table at all . Maybe we need to add v13.x with the replacement and leave the others blank until the backports are complete?
There was a problem hiding this comment.
I wasn't sure how to mark them either. Nevertheless, we need to replace the appropriate token on all branches whenever N-API 5 appears in any of them.
There was a problem hiding this comment.
Agreed, its just that I think there is some tooling related to REPLACEME and releases. @BethGriggs might know the specifics off the top of her head.
There was a problem hiding this comment.
@nodejs/releasers replace all of the REPLACEME placeholders when a release is cut: https://github.com/nodejs/node/blob/master/doc/releases.md#step-3-update-any-replaceme-and-dep00xx-tags-in-the-docs
If this landed on master and was then cherry-picked into 12.x then the entire column would be replaced with the 12.x release which would not be the desired result.
There was a problem hiding this comment.
Oh, I see, so, for each backport, the appropriate row must be marked as REPLACEME.
gabrielschulhof
force-pushed
the
update-napi-version-matrix
branch
from
91136af to
05959a3
Compare
gabrielschulhof
force-pushed
the
update-napi-version-matrix
branch
from
05959a3 to
86be81e
Compare
|
@richardlau @mhdawson I have updated the matrix, adding row "v13.x" and putting "REPLACEME" for N-API version 5. |
|
I've stuck |
|
Since this is a doc-only change, lite CI would be enough, so I'm going to ignore the fact that we don't have any LinuxONE machines available right now and say "linter passed, tests passed on other platforms, this is good to land". |
|
Landed in eaa9f83 |
PR-URL: #29461 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#29461 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#29461 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #29461 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
8 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes