Closed
Conversation
9 tasks
ronag
force-pushed
the
http-outgoing-cork
branch
3 times, most recently
from
961eefa to
0ddf57b
Compare
Member
Author
|
Not sure exactly how corking a http2 stream works. Would that cork other responses as well? Or does the multiplexing happen on a lower level? |
mscdex
reviewed
Aug 8, 2019
ronag
force-pushed
the
http-outgoing-cork
branch
3 times, most recently
from
92fa16b to
d54f0a5
Compare
Member
|
multiplexing happens on the native layer. corking an Http2Stream has no impact on any other Http2Stream instances. |
addaleax
approved these changes
Nov 3, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM, but this needs a rebase
ronag
force-pushed
the
http-outgoing-cork
branch
3 times, most recently
from
650eeab to
c650a63
Compare
addaleax
reviewed
Nov 4, 2019
ronag
force-pushed
the
http-outgoing-cork
branch
from
c650a63 to
796f541
Compare
Collaborator
Member
Author
|
Sorry, there is a test failure. Right now I can't build node due to:
I'll fix this once I've figured out how to build Node again. |
Member
Author
Member
ronag
force-pushed
the
http-outgoing-cork
branch
from
796f541 to
7290bf1
Compare
Member
Author
|
rebased |
Member
Author
|
@Trott failed on compile V8? |
Collaborator
Member
|
Test failures in test-http-response-cork: NaN !== undefined
at Server.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine-latest-x64/test/parallel/test-http-response-cork.js:15:10) |
ronag
force-pushed
the
http-outgoing-cork
branch
from
7290bf1 to
b5a611f
Compare
Member
Author
|
Hm, that was a minor bug in |
Collaborator
Member
|
@nodejs/http This could use more reviews. |
addaleax
approved these changes
Nov 13, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM but I’d put the _stream_duplex.js changes in a separate commit (while landing)
addaleax
added a commit
that referenced
this pull request
Nov 13, 2019
PR-URL: #29053 Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Nov 13, 2019
PR-URL: #29053 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #29053 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #29053 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
4 tasks
targos
added
the
semver-minor
targos
pushed a commit
that referenced
this pull request
Jan 13, 2020
PR-URL: #29053 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Jan 13, 2020
PR-URL: #29053 Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #29053 Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #29053 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements cork/uncork on
OutgoingMessageto make it more streamlike.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes