doc:add example function to fs.existsSync#28354
Closed
nicolasrestrepo wants to merge 1 commit intonodejs:masterfrom
Closed
doc:add example function to fs.existsSync#28354nicolasrestrepo wants to merge 1 commit intonodejs:masterfrom
nicolasrestrepo wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
Trott
previously requested changes
Jun 21, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Welcome @nicolasrestrepo and thanks for the pull request. The sample code does not follow our coding conventions and will (probably) result in an error if you run make lint-js (or vcbuild lint-js if you are on Windows). Can you adjust the indentation and end statements with semicolons, then run the appropriate lint-js command above to confirm that there isn't anything else to fix up? Thanks!
Trott
reviewed
Jun 21, 2019
Trott
reviewed
Jun 21, 2019
Trott
reviewed
Jun 21, 2019
nicolasrestrepo
force-pushed
the
fs-existSync-docs
branch
from
9a8b9fb to
198b969
Compare
addaleax
approved these changes
Jun 22, 2019
BridgeAR
approved these changes
Jun 22, 2019
trivikr
approved these changes
Jun 23, 2019
Trott
approved these changes
Jun 23, 2019
Member
Trott
added
the
author ready
jasnell
approved these changes
Jun 23, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 24, 2019
PR-URL: nodejs#28354 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in d4549e7. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28354 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add example function to fs.existsSync