test: use regex for OpenSSL function name

[danbev]

This commit modifies test-crypt-scrypt.js to use a regular expression
for the function name in the error message, similar to what is done for
the error code.

The motivation for this change comes from a case where we (Red Hat)
patch OpenSSL and the memory limit checking is done in a different
function, meaning that the function name from which this error
originates differs from that when linking to the OpenSSL version shipped
with Node.js.

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/23974/

[sam-github]

I'm OK with this as-is, but wonder if might be better to just switch the test to assert on the .code instead of the .message, which should be more stable going forward, even openssl might move the check around to a different code location.

[danbev]

I'm OK with this as-is, but wonder if might be better to just switch the test to assert on the .code

I like that, I'll make the changes. Thanks!

[danbev]

@sam-github Before I start I just wanted to mention that there currently is no .code property for this error, only a .message. Looking at the comment in the code it says:

// EVP_PBE_scrypt() does not always put errors on the error stack
// and therefore ToResult() may or may not return an exception
// object.  Return a sentinel value to inform JS land it should
// throw an ERR_CRYPTO_SCRYPT_PARAMETER_ERROR on our behalf.

But in the memory limit exceeded case there is indeed an exception which means that the exception will be thrown as is.

I'm happy to look into a solution but wanted to make sure this is what we actually want to do here and that the lack of .code property was taking into consideration (from looking at other parts of that test it would seem like there is a .code property but not in all cases).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24005/

[sam-github]

There aren't .code for everything, its unfortunate. It keeps getting better. So, a regex is probably best for this specific PR. Anything you can do to improve the situation is great, but likely the easy errors already have codes :-).

[danbev]

Re-build of failing node-test-commit-aix (✔️)

[danbev]

Landed in c1ee668.