test: improve test-async-hooks-http-parser-destroy#28253
test: improve test-async-hooks-http-parser-destroy#28253Flarna wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
added
the
author ready
|
I don't think all these test fails are caused by my changes... |
|
Seems the test I modified fails now in Other fails look unrelated to me. |
Ignore unrelated fails. To test the worker thing locally: |
|
According to docs the use of |
|
I was able to reproduce a similar fail locally and was able to fix it by closing server later. I haven't fully understood why this matters but it seems |
Improve asserts to distinguish between reequest and response parsers. Change the assert sequence to first assert on the number of ids to easier identify if some operation is missing/incomplete. Destroy HTTP agent once expected number of events have been seen to avoid waiting on socket timeouts. Refs: nodejs#28112
Flarna
force-pushed
the
test-async-hooks-http-parser-destroy
branch
from
e8b11c4 to
5ebef48
Compare
|
Rebased as indicated at #28610 (comment) - maybe this helps CI. If not I'm out of ideas and will abandon this one. |
|
If I understand CI correct again an unrelated fail from |
|
Landed in 8007134. |
Improve asserts to distinguish between reequest and response parsers. Change the assert sequence to first assert on the number of ids to easier identify if some operation is missing/incomplete. Destroy HTTP agent once expected number of events have been seen to avoid waiting on socket timeouts. Refs: nodejs#28112 PR-URL: nodejs#28253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Improve asserts to distinguish between reequest and response parsers. Change the assert sequence to first assert on the number of ids to easier identify if some operation is missing/incomplete. Destroy HTTP agent once expected number of events have been seen to avoid waiting on socket timeouts. Refs: #28112 PR-URL: #28253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
7 participants
Improve asserts to distinguish between reequest and response parsers.
Change the assert sequence to first assert on the number of ids to easier identify if some operation is missing/incomplete.
Destroy HTTP agent once expected number of events have been seen to avoid waiting on socket timeouts.
Refs: #28112
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes