doc: update kernel and glibc reqs for PPCle#28162
Closed
mhdawson wants to merge 3 commits intonodejs:masterfrom
Closed
doc: update kernel and glibc reqs for PPCle#28162mhdawson wants to merge 3 commits intonodejs:masterfrom
mhdawson wants to merge 3 commits intonodejs:masterfrom
Conversation
We've moved master to build on centos7 for PPCle, adjust the glibc and kernel levels accordingly.
Collaborator
|
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
added
build
richardlau
reviewed
Jun 10, 2019
Member
Author
|
@richardlau thanks for catching that, fixed. |
richardlau
approved these changes
Jun 11, 2019
Member
Author
|
@sam-github can you review as well? |
sam-github
approved these changes
Jun 11, 2019
mhdawson
added
the
author ready
Member
Author
BethGriggs
approved these changes
Jun 13, 2019
Contributor
|
Even after adjusting the format of #28162 (comment), |
pull bot
pushed a commit
to Rachelmorrell/node
that referenced
this pull request
Jun 13, 2019
We've moved master to build on centos7 for PPCle, adjust the glibc and kernel levels accordingly. PR-URL: nodejs#28162 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Member
|
Landed in 8cdc1bd |
Member
nodejs/node-core-utils#354 will fix this. |
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
We've moved master to build on centos7 for PPCle, adjust the glibc and kernel levels accordingly. PR-URL: #28162 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jun 18, 2019
We've moved master to build on centos7 for PPCle, adjust the glibc and kernel levels accordingly. PR-URL: #28162 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've moved master to build on centos7 for PPCle, adjust
the glibc and kernel levels accordingly.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes