http: fix test where aborted should not be emitted#28120
Closed
ronag wants to merge 1 commit intonodejs:masterfrom
Closed
http: fix test where aborted should not be emitted#28120ronag wants to merge 1 commit intonodejs:masterfrom
ronag wants to merge 1 commit intonodejs:masterfrom
Conversation
4 tasks
Member
Author
|
@cjihrig the point is that the test will NOT pass, this makes them fail (as they should?), but doesn't fix the underlying issue. I don't know how to fix it at the moment. |
This was referenced Jun 8, 2019
ronag
force-pushed
the
http-fix-aborted-test
branch
from
d3fbeee to
54a55bf
Compare
Member
Author
|
I think the tests failed because of a regression in |
Member
Author
|
I've included these test updates in #27984 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two http tests to properly catch a potential bug where
abortedis incorrectly emitted.I don't know how to fix the actual "bug".
Checklist