src: read break_node_first_line from the inspect options#28034
Closed
MarshallOfSound wants to merge 1 commit intonodejs:masterfrom
Closed
src: read break_node_first_line from the inspect options#28034MarshallOfSound wants to merge 1 commit intonodejs:masterfrom
MarshallOfSound wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
Collaborator
bnoordhuis
reviewed
Jun 6, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
The change itself LGTM but it needs a rebase. This section changed quite a bit but I think it's written like this now:
if (inspector_agent_->options().break_node_first_line) {
MarshallOfSound
force-pushed
the
use-agent-options
branch
from
e640735 to
f459ef3
Compare
Member
Author
|
Sorry for the delay on this @bnoordhuis , rebased and updated 👍 |
jasnell
approved these changes
Jun 23, 2019
BridgeAR
approved these changes
Jul 5, 2019
BridgeAR
added
the
author ready
Collaborator
Collaborator
Member
|
Is it reasonable to write a test for this? |
addaleax
approved these changes
Jul 14, 2019
Collaborator
Collaborator
There are cases where the debug_options() on the env are different to the options that were passed into inspector::Agent.
MarshallOfSound
force-pushed
the
use-agent-options
branch
from
f459ef3 to
633b385
Compare
Member
Collaborator
Member
Member
|
Landed in 4208158. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2019
There are cases where the debug_options() on the env are different to the options that were passed into inspector::Agent. PR-URL: nodejs#28034 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
There are cases where the debug_options() on the env are different to the options that were passed into inspector::Agent. PR-URL: #28034 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where the debug_options() on the env are different to the options that were passed into inspector::Agent. This is particularly true in Electrons case where we pass the agent a real parsed
NodeOptionsbut give the env an empty one.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes