doc: warn about relying on fs gc close behavior#27972
Closed
benjamingr wants to merge 3 commits intonodejs:masterfrom
Closed
doc: warn about relying on fs gc close behavior#27972benjamingr wants to merge 3 commits intonodejs:masterfrom
benjamingr wants to merge 3 commits intonodejs:masterfrom
Conversation
Warn about using the bahvior where file handles are closed automatically when the file is closed. PR-URL: Reviewed-By: Reviewed-By:
benjamingr
added
the
fs
addaleax
approved these changes
May 30, 2019
Trott
reviewed
May 30, 2019
Trott
reviewed
May 30, 2019
|
Thanks for this clarification. I think it's important that people understand that using finalizers is unreliable, and that they don't develop too strong expectations. For more context, see https://github.com/tc39/proposal-weakrefs/ . |
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Trott
approved these changes
May 30, 2019
cjihrig
approved these changes
May 30, 2019
Member
Trott
added
the
author ready
jasnell
approved these changes
May 30, 2019
antsmartian
approved these changes
May 30, 2019
lpinca
approved these changes
May 31, 2019
Member
|
Landed in 4c2345f |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 1, 2019
Warn about using the bahvior where file handles are closed automatically when the file is closed. PR-URL: nodejs#27972 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 1, 2019
Warn about using the bahvior where file handles are closed automatically when the file is closed. PR-URL: #27972 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn about using the bahavior where file handles are closed automatically when the file is closed.
ping @jasnell @littledan
make -j4 test(UNIX), orvcbuild test(Windows) passes