doc: add information to revoked deprecations#27952
Merged
cjihrig merged 1 commit intonodejs:masterfrom May 31, 2019
Merged
Conversation
richardlau
approved these changes
May 29, 2019
lpinca
approved these changes
May 29, 2019
trivikr
approved these changes
May 29, 2019
Trott
approved these changes
May 30, 2019
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/23490/ EDIT(cjihrig): CI was yellow. |
jasnell
approved these changes
May 31, 2019
Revoked deprecations are supposed to have some sort of information explaining why the deprecation was reversed. This commit adds some information to the two existing revoked deprecations. PR-URL: nodejs#27952 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 1, 2019
Revoked deprecations are supposed to have some sort of information explaining why the deprecation was reversed. This commit adds some information to the two existing revoked deprecations. PR-URL: #27952 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revoked deprecations are supposed to have some sort of information explaining why the deprecation was reversed. This commit adds some information to the two existing revoked deprecations.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes