Skip to content

src: export number_of_native_contexts and number_of_detached_contexts#27933

Closed
yvasiyarov wants to merge 3 commits intonodejs:masterfrom
yvasiyarov:get_heap_statistics
Closed

src: export number_of_native_contexts and number_of_detached_contexts#27933
yvasiyarov wants to merge 3 commits intonodejs:masterfrom
yvasiyarov:get_heap_statistics

Conversation

@yvasiyarov
Copy link

@yvasiyarov yvasiyarov commented May 28, 2019

export number_of_native_contexts and number_of_detached_contexts as
part of v8.getHeapStatistics()

Checklist
  • [ x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ x] tests and/or benchmarks are included
  • [x ] documentation is changed or added
  • [x ] commit message follows commit guidelines

src: export number_of_native_contexts and number_of_detached_contexts
84b1414 
export number_of_native_contexts and number_of_detached_contexts as
part of v8.getHeapStatistics()
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency. labels May 28, 2019
addaleax
addaleax approved these changes May 28, 2019
View reviewed changes
@addaleax addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label May 28, 2019
@yvasiyarov @addaleax
Update doc/api/v8.md
5cd3302 
Co-Authored-By: Anna Henningsen <github@addaleax.net>
bnoordhuis
bnoordhuis approved these changes May 28, 2019
View reviewed changes
@yvasiyarov @addaleax
Update doc/api/v8.md
86a2c21 
Co-Authored-By: Anna Henningsen <github@addaleax.net>
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2019
@yvasiyarov
Copy link
Author

yvasiyarov commented May 30, 2019

I've checked failed checks and its looks like random failures which can not be related to the current pull request:

  • test.sequential/test-http2-large-file
  • test.parallel/test-http2-client-upload
  • test.sequential/test-cpu-prof
    How can I run this checks again ?

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 30, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23478/

Trott pushed a commit to Trott/io.js that referenced this pull request May 30, 2019
@Trott
src: export number_of_native_contexts and number_of_detached_contexts
a40aae8 
export number_of_native_contexts and number_of_detached_contexts as
part of v8.getHeapStatistics()

PR-URL: nodejs#27933
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented May 30, 2019

Landed in a40aae8.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this May 30, 2019
targos pushed a commit that referenced this pull request May 31, 2019
@targos
src: export number_of_native_contexts and number_of_detached_contexts
33236b7 
export number_of_native_contexts and number_of_detached_contexts as
part of v8.getHeapStatistics()

PR-URL: #27933
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Merged
targos added a commit that referenced this pull request Jun 3, 2019
@targos
2019-06-04, Version 12.4.0 (Current)
6421974 
Notable changes:

* doc:
  * The JSON variant of the API documentation is no longer experimental
    (Rich Trott) #27842.
* esm:
  * JSON module support is always enabled under
    `--experimental-modules`. The `--experimental-json-modules` flag
    has been removed (Myles Borins)
    #27752.
* http,http2:
  * A new flag has been added for overriding the default HTTP server
    socket timeout (which is two minutes). Pass
    `--http-server-default-timeout=milliseconds`
    or `--http-server-default-timeout=0` to respectively change or
    disable the timeout. Starting with Node.js 13.0.0, the timeout will
    be disabled by default
    (Ali Ijaz Sheikh) #27704.
* inspector:
  * Added an experimental `--heap-prof` flag to start the V8 heap
    profiler on startup and write the heap profile to disk before exit
    (Joyee Cheung) #27596.
* stream:
  * The `readable.unshift()` method now correctly converts strings to
    buffers. Additionally, a new optional argument is accepted to
    specify the string's encoding, such as `'utf8'` or `'ascii'`
    (Marcos Casagrande) #27194.
* v8:
  * The object returned by `v8.getHeapStatistics()` has two new
    properties: `number_of_native_contexts` and
    `number_of_detached_contexts` (Yuriy Vasiyarov)
    #27933.

PR-URL: #28040
pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Jun 4, 2019
@targos
2019-06-04, Version 12.4.0 (Current)
cb68c04 
Notable changes:

* doc:
  * The JSON variant of the API documentation is no longer experimental
    (Rich Trott) nodejs#27842.
* esm:
  * JSON module support is always enabled under
    `--experimental-modules`. The `--experimental-json-modules` flag
    has been removed (Myles Borins)
    nodejs#27752.
* http,http2:
  * A new flag has been added for overriding the default HTTP server
    socket timeout (which is two minutes). Pass
    `--http-server-default-timeout=milliseconds`
    or `--http-server-default-timeout=0` to respectively change or
    disable the timeout. Starting with Node.js 13.0.0, the timeout will
    be disabled by default
    (Ali Ijaz Sheikh) nodejs#27704.
* inspector:
  * Added an experimental `--heap-prof` flag to start the V8 heap
    profiler on startup and write the heap profile to disk before exit
    (Joyee Cheung) nodejs#27596.
* stream:
  * The `readable.unshift()` method now correctly converts strings to
    buffers. Additionally, a new optional argument is accepted to
    specify the string's encoding, such as `'utf8'` or `'ascii'`
    (Marcos Casagrande) nodejs#27194.
* v8:
  * The object returned by `v8.getHeapStatistics()` has two new
    properties: `number_of_native_contexts` and
    `number_of_detached_contexts` (Yuriy Vasiyarov)
    nodejs#27933.

PR-URL: nodejs#28040
@ghost ghost deleted a comment Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. semver-minor PRs that contain new features and should be released in the next minor version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@yvasiyarov @nodejs-github-bot @Trott @bnoordhuis @addaleax @cjihrig @joyeecheung @BethGriggs